You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jd...@apache.org on 2009/09/15 20:50:40 UTC
svn commit: r815445 - in /wicket/trunk:
wicket-examples/src/main/java/org/apache/wicket/examples/frames/
wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/h...
Author: jdonnerstag
Date: Tue Sep 15 18:50:39 2009
New Revision: 815445
URL: http://svn.apache.org/viewvc?rev=815445&view=rev
Log:
removed false @SuppressWarnings("unchecked")
Modified:
wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/frames/BodyFrame.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/DefaultAbstractTree.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyRenderableColumn.java
wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyTreeColumn.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/list/ListView.java
wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolverConverter.java
Modified: wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/frames/BodyFrame.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/frames/BodyFrame.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/frames/BodyFrame.java (original)
+++ wicket/trunk/wicket-examples/src/main/java/org/apache/wicket/examples/frames/BodyFrame.java Tue Sep 15 18:50:39 2009
@@ -63,7 +63,6 @@
/**
* Constructor
*/
- @SuppressWarnings("unchecked")
public BodyFrame()
{
// create a new page instance, passing this 'master page' as an argument
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/captcha/kittens/KittenCaptchaPanel.java Tue Sep 15 18:50:39 2009
@@ -173,7 +173,6 @@
"&x=' + getEventX(this, event) + '&y=' + getEventY(this, event)");
}
- @SuppressWarnings("unchecked")
@Override
protected void onEvent(final AjaxRequestTarget target)
{
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/AbstractOptions.java Tue Sep 15 18:50:39 2009
@@ -63,8 +63,11 @@
protected abstract Iterator<T> getOptionsIterator();
-
- @SuppressWarnings("unchecked")
+ /**
+ *
+ * @see org.apache.wicket.MarkupContainer#onComponentTagBody(org.apache.wicket.markup.MarkupStream,
+ * org.apache.wicket.markup.ComponentTag)
+ */
@Override
protected void onComponentTagBody(MarkupStream markupStream, ComponentTag openTag)
{
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/palette/component/Recorder.java Tue Sep 15 18:50:39 2009
@@ -67,7 +67,6 @@
* @param palette
* parent palette object
*/
- @SuppressWarnings("unchecked")
public Recorder(String id, Palette<T> palette)
{
super(id);
@@ -76,6 +75,10 @@
setOutputMarkupId(true);
}
+ /**
+ *
+ * @see org.apache.wicket.markup.html.form.AbstractTextComponent#onBeforeRender()
+ */
@Override
protected void onBeforeRender()
{
@@ -162,7 +165,7 @@
if (choices.size() - ids.length == 0)
{
- return Collections.<T>emptyList().iterator();
+ return Collections.<T> emptyList().iterator();
}
List<T> unselected = new ArrayList<T>(Math.max(1, choices.size() - ids.length));
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/DefaultAbstractTree.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/DefaultAbstractTree.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/DefaultAbstractTree.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/DefaultAbstractTree.java Tue Sep 15 18:50:39 2009
@@ -19,7 +19,12 @@
import javax.swing.tree.TreeModel;
import javax.swing.tree.TreeNode;
-import org.apache.wicket.*;
+import org.apache.wicket.Component;
+import org.apache.wicket.IClusterable;
+import org.apache.wicket.MarkupContainer;
+import org.apache.wicket.RequestCycle;
+import org.apache.wicket.ResourceReference;
+import org.apache.wicket.Response;
import org.apache.wicket.ajax.AjaxRequestTarget;
import org.apache.wicket.ajax.markup.html.AjaxFallbackLink;
import org.apache.wicket.ajax.markup.html.AjaxLink;
@@ -42,9 +47,9 @@
* implement populateTreeItem() on your own. If you want to use an existing (complete) tree class,
* use {@link Tree}
* <p>
- * This class allows you to choose between 3 types of links. {@link
- * DefaultAbstractTree#setLinkType(org.apache.wicket.extensions.markup.html.tree.DefaultAbstractTree.LinkType)}
- *
+ * This class allows you to choose between 3 types of links.
+ * {@link DefaultAbstractTree#setLinkType(org.apache.wicket.extensions.markup.html.tree.DefaultAbstractTree.LinkType)}
+ *
* @author Matej Knopp
*/
public abstract class DefaultAbstractTree extends AbstractTree
@@ -84,7 +89,7 @@
/**
* Construct.
- *
+ *
* @param name
*/
public LinkType(String name)
@@ -95,14 +100,14 @@
/**
* Helper class for calling an action from a link.
- *
+ *
* @author Matej Knopp
*/
protected interface ILinkCallback extends IClusterable
{
/**
* Called when the click is executed.
- *
+ *
* @param target
* The ajax request target
*/
@@ -132,7 +137,7 @@
/**
* Tree constructor.
- *
+ *
* @param id
* The component id
*/
@@ -144,7 +149,7 @@
/**
* Tree constructor.
- *
+ *
* @param id
* The component id
* @param model
@@ -158,13 +163,12 @@
/**
* Tree constructor.
- *
+ *
* @param id
* The component id
* @param model
* The tree model
*/
- @SuppressWarnings("unchecked")
public DefaultAbstractTree(String id, TreeModel model)
{
super(id, new WicketTreeModel());
@@ -174,7 +178,7 @@
/**
* Returns the current type of links on tree items.
- *
+ *
* @return The link type
*/
public LinkType getLinkType()
@@ -185,7 +189,7 @@
/**
* Sets the type of links on tree items. After the link type is changed, the whole tree is
* rebuild and re-rendered.
- *
+ *
* @param linkType
* type of links
*/
@@ -200,7 +204,7 @@
/**
* Returns the resource reference of default stylesheet.
- *
+ *
* @return The package resource reference
*/
protected ResourceReference getCSS()
@@ -210,7 +214,7 @@
/**
* Returns the resource reference of default closed tree folder.
- *
+ *
* @return The package resource reference
*/
protected ResourceReference getFolderClosed()
@@ -220,7 +224,7 @@
/**
* Returns the resource reference of default open tree folder.
- *
+ *
* @return The package resource reference
*/
protected ResourceReference getFolderOpen()
@@ -230,7 +234,7 @@
/**
* Returns the resource reference of default tree item (not folder).
- *
+ *
* @return The package resource reference
*/
protected ResourceReference getItem()
@@ -240,7 +244,7 @@
/**
* Returns the resource reference for icon of specified tree node.
- *
+ *
* @param node
* The node
* @return The package resource reference
@@ -268,7 +272,7 @@
* Creates the indentation element. This element should be placed as first element in the tree
* item markup to ensure proper indentation of the tree item. This implementation also takes
* care of lines that connect nodes.
- *
+ *
* @param parent
* The component parent
* @param id
@@ -287,7 +291,8 @@
private static final long serialVersionUID = 1L;
/**
- * @see org.apache.wicket.MarkupContainer#onComponentTagBody(org.apache.wicket.markup.MarkupStream, org.apache.wicket.markup.ComponentTag)
+ * @see org.apache.wicket.MarkupContainer#onComponentTagBody(org.apache.wicket.markup.MarkupStream,
+ * org.apache.wicket.markup.ComponentTag)
*/
@Override
protected void onComponentTagBody(MarkupStream markupStream, ComponentTag openTag)
@@ -324,7 +329,7 @@
* Creates an image placed on junction link. This image actually consists of two spans with
* different css classes. These classes are specified according to the stylesheet to make the
* junction image look well together with lines connecting nodes.
- *
+ *
* @param parent
* The component parent
* @param id
@@ -370,17 +375,17 @@
/**
* Creates the junction link for given node. Also (optionally) creates the junction image. If
* the node is a leaf (it has no children), the created junction link is non-functional.
- *
+ *
* @param parent
* parent component of the link
- *
+ *
* @param id
* wicket:id of the component
- *
+ *
* @param imageId
* wicket:id of the image. this can be null, in that case image is not created. image
* is supposed to be placed on the link (link is parent of image)
- *
+ *
* @param node
* tree node for which the link should be created.
* @return The link component
@@ -418,7 +423,8 @@
private static final long serialVersionUID = 1L;
/**
- * @see org.apache.wicket.Component#onComponentTag(org.apache.wicket.markup.ComponentTag )
+ * @see org.apache.wicket.Component#onComponentTag(org.apache.wicket.markup.ComponentTag
+ * )
*/
@Override
protected void onComponentTag(ComponentTag tag)
@@ -441,7 +447,7 @@
/**
* Creates a link of type specified by current linkType. When the links is clicked it calls the
* specified callback.
- *
+ *
* @param parent
* The parent component
* @param id
@@ -506,7 +512,7 @@
/**
* Creates the icon for current node. By default uses image reference specified by
* {@link DefaultAbstractTree#getNodeIcon(TreeNode)}.
- *
+ *
* @param parent
* The parent component
* @param id
@@ -534,7 +540,7 @@
/**
* Creates a link that can be used to select / deselect the specified node.
- *
+ *
* @param parent
* The parent component
* @param id
@@ -561,10 +567,10 @@
/**
* Callback function called after user clicked on an junction link. The node has already been
* expanded/collapsed (depending on previous status).
- *
+ *
* @param target
* Request target - may be null on non-ajax call
- *
+ *
* @param node
* Node for which this callback is relevant
*/
@@ -574,10 +580,10 @@
/**
* This callback method is called after user has selected / deselected the given node.
- *
+ *
* @param target
* Request target - may be null on non-ajax call
- *
+ *
* @param node
* Node for which this this callback is fired.
*/
@@ -599,7 +605,7 @@
/**
* Returns whether the provided node is last child of it's parent.
- *
+ *
* @param node
* The node
* @return whether the provided node is the last child
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyRenderableColumn.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyRenderableColumn.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyRenderableColumn.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyRenderableColumn.java Tue Sep 15 18:50:39 2009
@@ -34,7 +34,6 @@
{
private static final long serialVersionUID = 1L;
- @SuppressWarnings("unchecked")
private IConverter converter;
private Locale locale;
@@ -83,7 +82,6 @@
/**
* @see AbstractRenderableColumn#getNodeValue(TreeNode)
*/
- @SuppressWarnings("unchecked")
@Override
public String getNodeValue(TreeNode node)
{
@@ -110,7 +108,6 @@
* @param converter
* any converter
*/
- @SuppressWarnings("unchecked")
public void setConverter(IConverter converter)
{
this.converter = converter;
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyTreeColumn.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyTreeColumn.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyTreeColumn.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/table/PropertyTreeColumn.java Tue Sep 15 18:50:39 2009
@@ -34,7 +34,6 @@
{
private static final long serialVersionUID = 1L;
- @SuppressWarnings("unchecked")
private IConverter converter;
private Locale locale;
@@ -64,7 +63,6 @@
*
* @return Any converter
*/
- @SuppressWarnings("unchecked")
public IConverter getConverter()
{
return converter;
@@ -84,7 +82,6 @@
* @see AbstractTreeColumn#renderNode(TreeNode)
*/
@Override
- @SuppressWarnings("unchecked")
public String renderNode(TreeNode node)
{
Object result = PropertyResolver.getValue(propertyExpression, node);
@@ -110,7 +107,6 @@
* @param converter
* Any converter
*/
- @SuppressWarnings("unchecked")
public void setConverter(IConverter converter)
{
this.converter = converter;
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/list/ListView.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/list/ListView.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/list/ListView.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/list/ListView.java Tue Sep 15 18:50:39 2009
@@ -26,7 +26,6 @@
import org.apache.wicket.markup.repeater.AbstractRepeater;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.Model;
-import org.apache.wicket.model.util.ListModel;
import org.apache.wicket.util.collections.ReadOnlyIterator;
import org.apache.wicket.version.undo.Change;
@@ -497,7 +496,8 @@
* The list item index
* @return The ListItemModel created
*/
- protected IModel<T> getListItemModel(final IModel<? extends List<T>> listViewModel, final int index)
+ protected IModel<T> getListItemModel(final IModel<? extends List<T>> listViewModel,
+ final int index)
{
return new ListItemModel<T>(this, index);
}
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolverConverter.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolverConverter.java?rev=815445&r1=815444&r2=815445&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolverConverter.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/util/lang/PropertyResolverConverter.java Tue Sep 15 18:50:39 2009
@@ -51,7 +51,6 @@
* @param clz
* @return The converted object
*/
- @SuppressWarnings("unchecked")
public Object convert(Object object, Class<?> clz)
{
if (object == null)