You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ak...@apache.org on 2018/12/22 11:26:25 UTC
svn commit: r1849540 -
/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
Author: akashjain
Date: Sat Dec 22 11:26:25 2018
New Revision: 1849540
URL: http://svn.apache.org/viewvc?rev=1849540&view=rev
Log:
Fixed: Date format does not change on change of locale.
(OFBIZ-10736)
Thanks, Aditi Patidar for your contribution.
Modified:
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1849540&r1=1849539&r2=1849540&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java Sat Dec 22 11:26:25 2018
@@ -1591,7 +1591,7 @@ public class ModelFormField {
Debug.logError(e, errMsg, module);
throw new IllegalArgumentException(errMsg);
}
- } else if ("date".equals(this.type) && retVal.length() > 10) {
+ } else if ("date".equals(this.type) && retVal.length() > 9) {
Locale locale = (Locale) context.get("locale");
if (locale == null) {
locale = Locale.getDefault();
Re: svn commit: r1849540 -
/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Akash,
Again a bit of explanation would fit here. Like why from 10 to 9.
Even if it's obvious when you look at it now, it could help later if another date format pose a problem (the earth is wide)
Thanks
Jacques
Le 22/12/2018 à 12:26, akashjain@apache.org a écrit :
> Author: akashjain
> Date: Sat Dec 22 11:26:25 2018
> New Revision: 1849540
>
> URL: http://svn.apache.org/viewvc?rev=1849540&view=rev
> Log:
> Fixed: Date format does not change on change of locale.
> (OFBIZ-10736)
> Thanks, Aditi Patidar for your contribution.
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java?rev=1849540&r1=1849539&r2=1849540&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java Sat Dec 22 11:26:25 2018
> @@ -1591,7 +1591,7 @@ public class ModelFormField {
> Debug.logError(e, errMsg, module);
> throw new IllegalArgumentException(errMsg);
> }
> - } else if ("date".equals(this.type) && retVal.length() > 10) {
> + } else if ("date".equals(this.type) && retVal.length() > 9) {
> Locale locale = (Locale) context.get("locale");
> if (locale == null) {
> locale = Locale.getDefault();
>
>
>