You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2024/06/06 11:26:04 UTC
[PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
mymeiyi opened a new pull request, #35995:
URL: https://github.com/apache/doris/pull/35995
## Proposed changes
1. Modify group commit p2 case to use nereids since https://github.com/apache/doris/pull/32523 support it.
2. We can many same logs when group commit is cancel:
```
group_commit_mgr.cpp:182] cancel group commit, instance_id=xx, label=xx, status=[OK]
```
the problem is that `runtime_state->is_cancelled` is true, but `runtime_state->cancel_reason()` is `OK`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152335734
<details>
<summary>TPC-H: <b>Total hot run time: 41343 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f44aabd524ba4d3a671322ca379256443c81008, data reload: false
------ Round 1 ----------------------------------
q1 17599 4428 4324 4324
q2 2024 199 194 194
q3 10493 1230 1157 1157
q4 10185 839 871 839
q5 7499 2763 2763 2763
q6 227 132 138 132
q7 952 602 639 602
q8 9221 2177 2131 2131
q9 9189 6683 6785 6683
q10 9260 3847 3912 3847
q11 445 238 237 237
q12 476 237 233 233
q13 18410 3213 3228 3213
q14 255 206 218 206
q15 515 474 482 474
q16 501 406 396 396
q17 1000 646 650 646
q18 8476 7879 7863 7863
q19 7794 1393 1549 1393
q20 636 326 333 326
q21 5108 3348 4125 3348
q22 421 336 352 336
Total cold run time: 120686 ms
Total hot run time: 41343 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4635 4435 4493 4435
q2 386 272 260 260
q3 3109 2936 2956 2936
q4 1919 1639 1605 1605
q5 5416 5503 5560 5503
q6 227 129 126 126
q7 2139 1865 1821 1821
q8 3338 3420 3405 3405
q9 8596 8602 8675 8602
q10 4142 3894 3885 3885
q11 592 492 479 479
q12 809 583 613 583
q13 16942 3121 3137 3121
q14 300 266 268 266
q15 529 471 491 471
q16 484 431 420 420
q17 1852 1541 1487 1487
q18 8021 7694 7413 7413
q19 1763 1570 1519 1519
q20 3045 1803 1761 1761
q21 4870 4760 4682 4682
q22 631 555 530 530
Total cold run time: 73745 ms
Total hot run time: 55310 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152384087
TeamCity be ut coverage result:
Function Coverage: 36.45% (8973/24615)
Line Coverage: 27.97% (73308/262073)
Region Coverage: 27.37% (38001/138818)
Branch Coverage: 23.99% (19291/80422)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4f44aabd524ba4d3a671322ca379256443c81008_4f44aabd524ba4d3a671322ca379256443c81008/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152400205
<details>
<summary>ClickBench: <b>Total hot run time: 30.73 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4f44aabd524ba4d3a671322ca379256443c81008, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.03 0.04
query3 0.23 0.05 0.05
query4 1.67 0.07 0.07
query5 0.50 0.48 0.50
query6 1.12 0.72 0.73
query7 0.02 0.01 0.02
query8 0.05 0.04 0.05
query9 0.53 0.49 0.48
query10 0.56 0.56 0.55
query11 0.15 0.11 0.12
query12 0.15 0.12 0.11
query13 0.59 0.58 0.59
query14 0.79 0.77 0.79
query15 0.83 0.82 0.81
query16 0.37 0.36 0.37
query17 1.03 1.04 1.04
query18 0.22 0.25 0.25
query19 1.92 1.74 1.83
query20 0.02 0.01 0.00
query21 15.56 0.68 0.68
query22 4.45 6.92 1.95
query23 18.29 1.37 1.30
query24 2.20 0.22 0.21
query25 0.18 0.08 0.09
query26 0.27 0.17 0.18
query27 0.08 0.09 0.09
query28 13.23 1.01 1.00
query29 13.08 3.31 3.30
query30 0.25 0.05 0.05
query31 2.88 0.39 0.38
query32 3.28 0.46 0.49
query33 2.86 2.96 2.90
query34 17.00 4.37 4.41
query35 4.44 4.52 4.57
query36 0.69 0.50 0.46
query37 0.18 0.16 0.15
query38 0.16 0.15 0.15
query39 0.05 0.03 0.04
query40 0.16 0.14 0.15
query41 0.09 0.05 0.04
query42 0.05 0.05 0.04
query43 0.04 0.03 0.04
Total cold run time: 110.34 s
Total hot run time: 30.73 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152610097
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152114723
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152134586
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #35995:
URL: https://github.com/apache/doris/pull/35995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152610182
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152128544
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](group commit) Modify group commit case and modify cancel status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35995:
URL: https://github.com/apache/doris/pull/35995#issuecomment-2152377654
<details>
<summary>TPC-DS: <b>Total hot run time: 171562 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f44aabd524ba4d3a671322ca379256443c81008, data reload: false
query1 924 390 380 380
query2 6442 2462 2294 2294
query3 6643 206 211 206
query4 19305 17402 17195 17195
query5 4124 464 451 451
query6 244 155 168 155
query7 4582 301 297 297
query8 334 292 289 289
query9 8661 2464 2443 2443
query10 424 294 262 262
query11 10598 10137 10042 10042
query12 130 89 84 84
query13 1654 361 368 361
query14 9437 7543 6004 6004
query15 221 181 184 181
query16 7797 273 266 266
query17 1298 520 514 514
query18 1951 274 274 274
query19 207 148 169 148
query20 90 84 82 82
query21 209 135 131 131
query22 4253 4136 3990 3990
query23 33385 32911 33006 32911
query24 11282 2785 2817 2785
query25 631 344 363 344
query26 1384 159 157 157
query27 3055 329 321 321
query28 7430 2049 2061 2049
query29 935 640 606 606
query30 287 150 154 150
query31 944 737 715 715
query32 94 51 55 51
query33 761 277 270 270
query34 992 476 478 476
query35 744 614 607 607
query36 1060 962 940 940
query37 153 69 73 69
query38 2832 2753 2734 2734
query39 877 790 806 790
query40 207 126 127 126
query41 57 53 52 52
query42 117 98 101 98
query43 591 539 547 539
query44 1223 729 736 729
query45 193 173 161 161
query46 1069 689 732 689
query47 1860 1753 1775 1753
query48 380 300 295 295
query49 993 407 408 407
query50 775 396 393 393
query51 6849 6592 6714 6592
query52 101 92 94 92
query53 354 288 284 284
query54 877 469 446 446
query55 74 74 71 71
query56 275 270 262 262
query57 1142 1037 1071 1037
query58 254 244 235 235
query59 3462 3042 3277 3042
query60 285 281 300 281
query61 91 90 89 89
query62 645 436 453 436
query63 320 286 288 286
query64 8876 2166 1758 1758
query65 3174 3085 3133 3085
query66 857 344 339 339
query67 15435 14929 15030 14929
query68 4492 561 530 530
query69 468 417 366 366
query70 1140 1142 1104 1104
query71 373 288 277 277
query72 7203 5629 5433 5433
query73 747 334 329 329
query74 5858 5518 5558 5518
query75 3390 2728 2700 2700
query76 2320 865 895 865
query77 451 295 305 295
query78 10477 9904 9834 9834
query79 1842 519 517 517
query80 2517 500 467 467
query81 603 222 222 222
query82 1061 109 109 109
query83 332 172 172 172
query84 275 87 94 87
query85 1372 340 318 318
query86 470 326 325 325
query87 3291 3075 3027 3027
query88 3524 2451 2433 2433
query89 475 394 375 375
query90 1874 186 190 186
query91 140 108 112 108
query92 70 51 55 51
query93 1778 516 494 494
query94 1311 205 203 203
query95 419 321 326 321
query96 596 275 270 270
query97 3137 3007 2990 2990
query98 223 210 210 210
query99 1181 896 978 896
Total cold run time: 270320 ms
Total hot run time: 171562 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org