You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2017/08/30 09:16:14 UTC
spark git commit: [MINOR][TEST] Off -heap memory leaks for unit tests
Repository: spark
Updated Branches:
refs/heads/master e47f48c73 -> d4895c9de
[MINOR][TEST] Off -heap memory leaks for unit tests
## What changes were proposed in this pull request?
Free off -heap memory .
I have checked all the unit tests.
## How was this patch tested?
N/A
Author: liuxian <li...@zte.com.cn>
Closes #19075 from 10110346/memleak.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/d4895c9d
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/d4895c9d
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/d4895c9d
Branch: refs/heads/master
Commit: d4895c9de6ca9c3ac4461cf6f86cd88eb63e0720
Parents: e47f48c
Author: liuxian <li...@zte.com.cn>
Authored: Wed Aug 30 10:16:11 2017 +0100
Committer: Sean Owen <so...@cloudera.com>
Committed: Wed Aug 30 10:16:11 2017 +0100
----------------------------------------------------------------------
.../src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java | 1 +
.../test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/d4895c9d/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java
----------------------------------------------------------------------
diff --git a/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java b/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java
index a77ba82..4ae49d8 100644
--- a/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java
+++ b/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java
@@ -73,5 +73,6 @@ public class PlatformUtilSuite {
Assert.assertEquals(
Platform.getByte(offheap.getBaseObject(), offheap.getBaseOffset()),
MemoryAllocator.MEMORY_DEBUG_FILL_CLEAN_VALUE);
+ MemoryAllocator.UNSAFE.free(offheap);
}
}
http://git-wip-us.apache.org/repos/asf/spark/blob/d4895c9d/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java b/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java
index f53bc0b..46b0516 100644
--- a/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java
+++ b/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java
@@ -54,6 +54,7 @@ public class TaskMemoryManagerSuite {
final long encodedAddress = manager.encodePageNumberAndOffset(dataPage, offset);
Assert.assertEquals(null, manager.getPage(encodedAddress));
Assert.assertEquals(offset, manager.getOffsetInPage(encodedAddress));
+ manager.freePage(dataPage, c);
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org