You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/09/20 08:38:03 UTC

[GitHub] [zeppelin] Reamer opened a new pull request, #4466: [ZEPPELIN-5824] Checkstyle

Reamer opened a new pull request, #4466:
URL: https://github.com/apache/zeppelin/pull/4466

   ### What is this PR for?
   This PullRequest introduces the new sub-module "build-tools". This allows the complete Zeppelin project to use the packed Checkstyke configuration centrally.
   It is not possible to use Checkstyle in the Zeppelin Parent project, otherwise there will be a cyclic dependency to the sub-module.
   
   The build-tools submodule was created on the recommendation of the check-style developers. See https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html
   
   This PR also removes the Scala style configuration. I have found no usage of the configuration. In addition to the Scala style configuration, XML validation was also thrown out. This is done by the IDE or by Maven itself.
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5824
   
   ### How should this be tested?
   * CI
   
   ### Questions:
   * Does the licenses files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4466: [ZEPPELIN-5824] Checkstyle

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4466:
URL: https://github.com/apache/zeppelin/pull/4466#issuecomment-1262264493

   The name of the module comes from the [Checkstyle documentation](https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html).
   I have found other projects which have adopted the folder name. e.g. https://github.com/microsoft/azure-maven-plugins/tree/develop/build-tools
   I'm willing to change the name, I just can't think of a better one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul merged pull request #4466: [ZEPPELIN-5824] Checkstyle

Posted by GitBox <gi...@apache.org>.
jongyoul merged PR #4466:
URL: https://github.com/apache/zeppelin/pull/4466


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul commented on pull request #4466: [ZEPPELIN-5824] Checkstyle

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4466:
URL: https://github.com/apache/zeppelin/pull/4466#issuecomment-1263375267

   Me neither to think of a better name. Let's merge it and find it later. Thank you for taking care of it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org