[GitHub] [calcite] danny0405 commented on a change in pull request #1271: [CALCITE-3112]Support Window in RelToSqlConverter

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1271: [CALCITE-3112]Support Window in RelToSqlConverter
URL: https://github.com/apache/calcite/pull/1271#discussion_r294778935
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
 ##########
 @@ -203,6 +205,30 @@ public Result visit(Project e) {
     return builder.result();
   }
 
+  /** @see #dispatch */
+  public Result visit(Window e) {
+    Result x = visitChild(0, e.getInput());
+    Builder builder = x.builder(e);
+    RelNode input = e.getInput();
+    int inputFieldCount = input.getRowType().getFieldCount();
+    List<SqlNode> rexOvers = new ArrayList<>();
+    for (Window.Group group: e.groups) {
+      rexOvers.addAll(builder.context.toSql(group, e.constants, inputFieldCount));
+    }
+    List<SqlNode> selectList = new ArrayList<>();
+
 
 Review comment:
   Add final modifier for all the containers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services