[GitHub] [kafka] mimaison commented on a diff in pull request #10244: KAFKA-12399: Deprecate Log4J Appender

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #10244:
URL: https://github.com/apache/kafka/pull/10244#discussion_r1127686145


##########
bin/kafka-run-class.sh:
##########
@@ -222,6 +234,7 @@ fi
 
 # Log4j settings
 if [ -z "$KAFKA_LOG4J_OPTS" ]; then
+  echo "DEPRECATED: using log4j 1.x configuration. To use log4j 2.x configuration, run with: 'export KAFKA_LOG4J_OPTS=\"-Dlog4j.configurationFile=file:$base_dir/config/tools-log4j2.properties\"'"

Review Comment:
   This will trigger if you run `kafka-run-class.sh kafka.Kafka`. As we expect most users to use `kafka-server-start.sh`, it's probably not a big deal.



##########
bin/kafka-run-class.sh:
##########
@@ -63,7 +63,10 @@ shopt -s nullglob
 if [ -z "$UPGRADE_KAFKA_STREAMS_TEST_VERSION" ]; then
   for dir in "$base_dir"/core/build/dependant-libs-${SCALA_VERSION}*;
   do
-    CLASSPATH="$CLASSPATH:$dir/*"
+    for file in "$dir"/*;

Review Comment:
   Why do we need these changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org