[jira] [Commented] (FINERACT-821) Enable and enforce (!) Checkstyle in Fineract

["Wandji Collins (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099822#comment-17099822 ] 

Wandji Collins commented on FINERACT-821:
-----------------------------------------

I'm currently working on this.

> Enable and enforce (!) Checkstyle in Fineract
> ---------------------------------------------
>
>                 Key: FINERACT-821
>                 URL: https://issues.apache.org/jira/browse/FINERACT-821
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> as suggested in FINERACT-712, we really should enable Checkstyle in Fineract.
> My past experience in such matters, confirmed by FINERACT-702, is that these things only ever work and have a lasting effect if you bulk fix all violations and switch on enforcement. If you only report, it's mostly useless.
> As for specific Checkstyle rules, I have spent a fair amount of time in a past life on a project (which I'm currently no longer actively invoved in) to refine a what I believe to be "good" Checkstyle rule set, we could reuse this for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)