[GitHub] [ozone] prashantpogde commented on pull request #3981: HDDS-7508. [Snapshot] Finish TestOMSnapshotDAG, restore CompactionNode SnapshotID field for debugging

[GitBox <gi...@apache.org>]

prashantpogde commented on PR #3981:
URL: https://github.com/apache/ozone/pull/3981#issuecomment-1329966857

   LGTM. But I suspect the result can be different if the RocksDB behavior changes. We should have a way to directly call the 
   rocksDB compaction lister and generate the deterministic DAG that we want to generate.Such a DAG traversal can give a constant output result. 
   I guess the current PR can go in as it is. But this is the idea for a next PR that will be very deterministic. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org