You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by en...@apache.org on 2008/10/08 10:25:34 UTC
svn commit: r702752 - in /hadoop/core/trunk: .eclipse.templates/.classpath
CHANGES.txt lib/hsqldb-1.8.0.10.LICENSE.txt lib/hsqldb-1.8.0.10.jar
lib/hsqldb-LICENSE.txt lib/hsqldb.jar
src/examples/org/apache/hadoop/examples/DBCountPageView.java
Author: enis
Date: Wed Oct 8 01:25:33 2008
New Revision: 702752
URL: http://svn.apache.org/viewvc?rev=702752&view=rev
Log:
HADOOP-4267. Occasional exceptions during shutting down HSQLDB is logged but not rethrown. Contributed by Enis Soztutar.
Added:
hadoop/core/trunk/lib/hsqldb-1.8.0.10.LICENSE.txt
- copied unchanged from r702747, hadoop/core/trunk/lib/hsqldb-LICENSE.txt
hadoop/core/trunk/lib/hsqldb-1.8.0.10.jar
- copied unchanged from r702747, hadoop/core/trunk/lib/hsqldb.jar
Removed:
hadoop/core/trunk/lib/hsqldb-LICENSE.txt
hadoop/core/trunk/lib/hsqldb.jar
Modified:
hadoop/core/trunk/.eclipse.templates/.classpath
hadoop/core/trunk/CHANGES.txt
hadoop/core/trunk/src/examples/org/apache/hadoop/examples/DBCountPageView.java
Modified: hadoop/core/trunk/.eclipse.templates/.classpath
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/.eclipse.templates/.classpath?rev=702752&r1=702751&r2=702752&view=diff
==============================================================================
--- hadoop/core/trunk/.eclipse.templates/.classpath (original)
+++ hadoop/core/trunk/.eclipse.templates/.classpath Wed Oct 8 01:25:33 2008
@@ -19,7 +19,7 @@
<classpathentry kind="lib" path="lib/commons-logging-1.0.4.jar"/>
<classpathentry kind="lib" path="lib/commons-logging-api-1.0.4.jar"/>
<classpathentry kind="lib" path="lib/commons-net-1.4.1.jar"/>
- <classpathentry kind="lib" path="lib/hsqldb.jar"/>
+ <classpathentry kind="lib" path="lib/hsqldb-1.8.0.10.jar"/>
<classpathentry kind="lib" path="lib/jets3t-0.6.1.jar"/>
<classpathentry kind="lib" path="lib/jetty-5.1.4.jar"/>
<classpathentry kind="lib" path="lib/jetty-ext/commons-el.jar"/>
Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=702752&r1=702751&r2=702752&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Wed Oct 8 01:25:33 2008
@@ -867,6 +867,9 @@
HADOOP-4256. Removes Completed and Failed Job tables from
jobqueue_details.jsp. (Sreekanth Ramakrishnan via ddas)
+ HADOOP-4267. Occasional exceptions during shutting down HSQLDB is logged
+ but not rethrown. (enis)
+
Release 0.18.2 - Unreleased
BUG FIXES
Modified: hadoop/core/trunk/src/examples/org/apache/hadoop/examples/DBCountPageView.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/examples/org/apache/hadoop/examples/DBCountPageView.java?rev=702752&r1=702751&r2=702752&view=diff
==============================================================================
--- hadoop/core/trunk/src/examples/org/apache/hadoop/examples/DBCountPageView.java (original)
+++ hadoop/core/trunk/src/examples/org/apache/hadoop/examples/DBCountPageView.java Wed Oct 8 01:25:33 2008
@@ -49,6 +49,7 @@
import org.apache.hadoop.mapred.lib.db.DBInputFormat;
import org.apache.hadoop.mapred.lib.db.DBOutputFormat;
import org.apache.hadoop.mapred.lib.db.DBWritable;
+import org.apache.hadoop.util.StringUtils;
import org.apache.hadoop.util.Tool;
import org.apache.hadoop.util.ToolRunner;
import org.hsqldb.Server;
@@ -99,13 +100,22 @@
connection.setAutoCommit(false);
}
- private void shutdown() throws SQLException {
- connection.commit();
- connection.close();
-
- if(server != null) {
- server.stop();
- server.shutdown();
+ private void shutdown() {
+ try {
+ connection.commit();
+ connection.close();
+ }catch (Throwable ex) {
+ LOG.warn("Exception occurred while closing connection :"
+ + StringUtils.stringifyException(ex));
+ } finally {
+ try {
+ if(server != null) {
+ server.shutdown();
+ }
+ }catch (Throwable ex) {
+ LOG.warn("Exception occurred while shutting down HSQLDB :"
+ + StringUtils.stringifyException(ex));
+ }
}
}