You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/31 10:35:32 UTC

[GitHub] kiszk opened a new pull request #23420: [SPARK-26508][Core][SQL] Address warning messages in Java reported at lgtm.com

kiszk opened a new pull request #23420: [SPARK-26508][Core][SQL] Address warning messages in Java reported at lgtm.com
URL: https://github.com/apache/spark/pull/23420
 
 
   ## What changes were proposed in this pull request?
   
   This PR addresses warning messages in Java files reported at [lgtm.com](https://lgtm.com).
   
   [lgtm.com](https://lgtm.com) provides automated code review of Java/Python/JavaScript files for OSS projects. [Here](https://lgtm.com/projects/g/apache/spark/alerts/?mode=list&severity=warning) are warning messages regarding Apache Spark project.
   
   This PR addresses the following warnings:
   
   - Result of multiplication cast to wider type
   - Implicit narrowing conversion in compound assignment
   - Boxed variable is never null
   - Useless null check
   
   NOTE: `Potential input resource leak` looks false positive for now.
   
   ## How was this patch tested?
   
   Existing UTs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org