You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/01/17 10:42:26 UTC
[GitHub] flink pull request #3136: [FLINK-5512] [doc] Improve RabbitMQ documentation
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3136
[FLINK-5512] [doc] Improve RabbitMQ documentation
Added information about non-parallel restriction for RabbitMQ source in order to achieve exactly-once.
Also attempted to overall improve the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-5512
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3136
----
commit 00a38fc4cf8cb05c2a22925328adcae6dd749f41
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-01-17T10:38:50Z
[FLINK-5512] [doc] Improve RabbitMQ documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3136: [FLINK-5512] [doc] Improve RabbitMQ documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3136: [FLINK-5512] [doc] Improve RabbitMQ documentation
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3136
Very helpful. But I did stumble on this sentence -- I'm not sure what "of a queue" is telling me.
> This limitation is mainly due to RabbitMQ's approach to dispatching messages of a queue across multiple consumers.
Would it be accurate to say "... dispatching messages from a single queue to multiple consumers" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3136: [FLINK-5512] [doc] Improve RabbitMQ documentation
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3136
Very nice, +1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3136: [FLINK-5512] [doc] Improve RabbitMQ documentation
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3136
Thanks @StephanEwen and @alpinegizmo for the review.
I think the re-wording for "of a queue" is definitely an improvement.
I'll change it to your suggestion and merge this by the end of the day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---