You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "jay vyas (JIRA)" <ji...@apache.org> on 2014/05/24 01:36:03 UTC

[jira] [Comment Edited] (BIGTOP-1269) BigPetStore: Create build w/ gradle

    [ https://issues.apache.org/jira/browse/BIGTOP-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007880#comment-14007880 ] 

jay vyas edited comment on BIGTOP-1269 at 5/23/14 11:34 PM:
------------------------------------------------------------

Looks like some technical issues.  but overall I think this is a pretty good patch.

1) Trailing whitespace errors.  You can  easily have intellij fix this for you : See BIGTOP-1240 for details.  

2) It looks like we've lost the classpath isolation that the original maven profiles encapsulated.  We will want to retain this so that all the individual integration tests can run under different classpaths.  For example, if "X" relies on a new version of zookeeper  and "Y" relies on a new version of zookeeper, we want X and Y to have independently scoped dependencies in their builds.   

3) The build fails when I ran it locally on my mac with {{gradle clean build}}
{noformat}
Total time: 24.005 secs
07:26:55 {master} $ gradle clean build
:clean UP-TO-DATE
:compileJava

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':compile'.
> Could not download artifact 'org.apache.avro:avro-ipc:1.7.4:avro-ipc-tests.jar'
   > Artifact 'org.apache.avro:avro-ipc:1.7.4:avro-ipc-tests.jar' not found.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 7.945 secs
{noformat}

All in all though this is a great first start.  


was (Author: jayunit100):
Looks like some technical issues.  but overall I think this is a pretty good patch.

1) Trailing whitespace errors.  You can  easily have intellij fix this for you : See BIGTOP-1240 for details.  

2) It looks like we've lost the classpath isolation that the original maven profiles encapsulated.  We will want to retain this so that all the individual integration tests can run under different classpaths.  For example, if "X" relies on a new version of zookeeper  and "Y" relies on a new version of zookeeper, we want X and Y to have independently scoped dependencies in their builds.   

3) The build fails when I ran it locally on my mac: 
{noformat}
Total time: 24.005 secs
07:26:55 {master} $ gradle clean build
:clean UP-TO-DATE
:compileJava

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':compile'.
> Could not download artifact 'org.apache.avro:avro-ipc:1.7.4:avro-ipc-tests.jar'
   > Artifact 'org.apache.avro:avro-ipc:1.7.4:avro-ipc-tests.jar' not found.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 7.945 secs
{noformat}

All in all though this is a great first start.  

> BigPetStore: Create build w/ gradle
> -----------------------------------
>
>                 Key: BIGTOP-1269
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1269
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Blueprints
>    Affects Versions: backlog
>            Reporter: jay vyas
>         Attachments: BIGTOP-1269.patch
>
>
> Lets port the BigPetStore build to gradle for all the obvious reasons.  This port might cause some minor breakage of other parallel efforts that change the pom file.
> The gradle ported build should contain: 
> - a "test" phase which runs the custom data set generator
> - a "integration test - pig" phase which runs the pig data cleaner + aggrergator. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)