You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/10 16:47:17 UTC

[GitHub] [trafficserver] dragon512 commented on a change in pull request #7177: Create an explicit runroot.yaml for AuTests

dragon512 commented on a change in pull request #7177:
URL: https://github.com/apache/trafficserver/pull/7177#discussion_r486488690



##########
File path: tests/gold_tests/autest-site/trafficserver.test.ext
##########
@@ -125,7 +136,6 @@ def MakeATSProcess(obj, name, command='traffic_server', select_ports=True,
     #########################################################
     # create subdirectories that need to exist (but are empty)
     # log directory has to be created with correct permissions
-    p.Setup.MakeDir(log_dir)  # log directory has to be created
     p.Setup.Chown(log_dir, "nobody", "nobody", ignore=True)
     # covers ubuntu's unprivileged group
     p.Setup.Chown(log_dir, "nobody", "nogroup", ignore=True)

Review comment:
       I think we can replace these Chown with one `traffic_layout verify --fix` command




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org