[jira] [Commented] (NIFI-3334) Processor Run Duration does not take effect if clicking Apply from tab other than Scheduling

["James Wing (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898428#comment-15898428 ] 

James Wing commented on NIFI-3334:
----------------------------------

Run duration is indeed selectively saved based on the visibility of the slider control.  This was added in [b19ff7c|https://github.com/apache/nifi/commit/b19ff7cf37162934cafabdf46dedd4afc46f2a82#diff-eec951084f43962cd777a891da3ffd88].  When saving the properties, the code checks if the slider control is visible (from nf-processor-configuration.js, line ~336):

{code}
        // run duration
        if ($('#run-duration-setting-container').is(':visible')) {
            var runDurationIndex = $('#run-duration-slider').slider('value');
            processorConfigDto['runDurationMillis'] = RUN_DURATION_VALUES[runDurationIndex];
        }
{code}

The check for visible evaluates false when the tab is not active, and it does not save.

[~mcgilman], do you remember why this is so?  It appears that the intent was to only display and save the slider data for processors that support batching.  Would it be OK to change it to {{if (processor.supportsBatching === true)}}, which is used to initialize the slider visibility (line ~680)?

{code}
                    // set the run duration if applicable
                    if (processor.supportsBatching === true) {
                        $('#run-duration-setting-container').show();
{code}

> Processor Run Duration does not take effect if clicking Apply from tab other than Scheduling
> --------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3334
>                 URL: https://issues.apache.org/jira/browse/NIFI-3334
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>            Reporter: Mark Payne
>
> If I create a processor and change the Run Duration in the Scheduling tab, and then I click Apply while still on the Scheduling tab, then I go back into the configuration dialog, I see that the Run Duration is still properly set. However, if I change the Run Duration, then switch to the Settings or Properties tab, and then click Apply from that tab, the settings do not take affect -- in that case, when I click configure again, I see Run Duration set to the default of 0 ms.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)