You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xupefei (via GitHub)" <gi...@apache.org> on 2024/05/22 14:27:12 UTC
Re: [PR] [SPARK-48008] Support UDAFs in Spark Connect [spark]
xupefei commented on code in PR #46245:
URL: https://github.com/apache/spark/pull/46245#discussion_r1610084616
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/UserDefinedFunctionE2ETestSuite.scala:
##########
@@ -346,4 +347,42 @@ class UserDefinedFunctionE2ETestSuite extends QueryTest {
val result = df.select(f($"id")).as[Long].head()
assert(result == 1L)
}
+
+ test("UDAF custom Aggregator - primitive types") {
Review Comment:
Let's do this in the next PR where we add support of `toColumn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org