You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fucun Chu (Code Review)" <ge...@cloudera.org> on 2021/07/25 05:30:40 UTC
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Fucun Chu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17726
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
This patch appends the username of the client who made the request to
close a session or cancel a query from the coordinator's debug WebUI.
Tests:
- Run related tests manually for use authentication
Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
---
M be/src/kudu/util/web_callback_registry.h
M be/src/service/impala-http-handler.cc
M be/src/util/webserver.cc
M tests/webserver/test_web_pages.py
4 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17726/2
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7357/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 6
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 07:00:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 5
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 07:00:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9195/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 01:45:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
This patch appends the username of the client who made the request to
close a session or cancel a query from the coordinator's debug WebUI.
Tests:
- Added a new fe test for LDAP auth to verify that the new status gets
printed in runtime profile and coordinator log when a query is
cancelled in this way.
Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
---
M be/src/kudu/util/web_callback_registry.h
M be/src/service/impala-http-handler.cc
M be/src/util/webserver.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
M tests/webserver/test_web_pages.py
6 files changed, 96 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17726/4
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 6
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 13:18:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 5:
(2 comments)
Thanks for the review! Addressed the comments.
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java:
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@103
PS4, Line 103: execQuery
> nit: rename it to 'execQueryAsync' since we won't wait for results here.
Done
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@338
PS4, Line 338: // Wait for logs to flush
> Shouldn't we do this after sleep?
Done
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 5
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 05:25:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
This patch appends the username of the client who made the request to
close a session or cancel a query from the coordinator's debug WebUI.
Tests:
- Added a new fe test for LDAP auth to verify that the new status gets
printed in runtime profile and coordinator log when a query is
cancelled in this way.
Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
---
M be/src/kudu/util/web_callback_registry.h
M be/src/service/impala-http-handler.cc
M be/src/util/webserver.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
M tests/webserver/test_web_pages.py
6 files changed, 96 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17726/3
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17726/3/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:
http://gerrit.cloudera.org:8080/#/c/17726/3/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@350
PS3, Line 350: String closeStatus = String.format("Session closed from Impala's debug web interface"
line too long (94 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 01:17:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 6
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 07:00:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
This patch appends the username of the client who made the request to
close a session or cancel a query from the coordinator's debug WebUI.
Tests:
- Added a new fe test for LDAP auth to verify that the new status gets
printed in runtime profile and coordinator log when a query is
cancelled in this way.
Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Reviewed-on: http://gerrit.cloudera.org:8080/17726
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/kudu/util/web_callback_registry.h
M be/src/service/impala-http-handler.cc
M be/src/util/webserver.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
M tests/webserver/test_web_pages.py
6 files changed, 96 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 7
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9160/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 2
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 25 Jul 2021 05:52:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
This patch appends the username of the client who made the request to
close a session or cancel a query from the coordinator's debug WebUI.
Tests:
- Added a new fe test for LDAP auth to verify that the new status gets
printed in runtime profile and coordinator log when a query is
cancelled in this way.
Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
---
M be/src/kudu/util/web_callback_registry.h
M be/src/service/impala-http-handler.cc
M be/src/util/webserver.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
M tests/webserver/test_web_pages.py
6 files changed, 96 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17726/5
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 5
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9194/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 01:38:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Thanks for adding the tests! I'm going to +2 this after the minor comments are resolved.
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java:
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@103
PS4, Line 103: execQuery
nit: rename it to 'execQueryAsync' since we won't wait for results here.
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
File fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:
http://gerrit.cloudera.org:8080/#/c/17726/4/fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java@338
PS4, Line 338: response = metrics_.readContent("/logs");
Shouldn't we do this after sleep?
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 03:02:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Fucun Chu (Code Review)" <ge...@cloudera.org>.
Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 3:
Added a new test for LDAP auth in LdapWebserverTest.java
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 3
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 01:19:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17726 )
Change subject: IMPALA-10779: Print the username closing a session or cancelling a query from the WebUI
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9196/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c92b5caee61d1f9f381cd2906a850e02c54d55
Gerrit-Change-Number: 17726
Gerrit-PatchSet: 5
Gerrit-Owner: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <ch...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 28 Jul 2021 05:46:18 +0000
Gerrit-HasComments: No