You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by mg...@apache.org on 2011/01/14 20:14:00 UTC

svn commit: r1059125 - /wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java

Author: mgrigorov
Date: Fri Jan 14 19:13:59 2011
New Revision: 1059125

URL: http://svn.apache.org/viewvc?rev=1059125&view=rev
Log:
WICKET-3333 Links with multiple parameters are wrongly generated
WICKET-2829 Tag attributes values are not escaped properly during writeOutput

Don't XML escape the link url. It is escaped in a central place (see WICKET-2829)

Modified:
    wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java

Modified: wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java?rev=1059125&r1=1059124&r2=1059125&view=diff
==============================================================================
--- wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java (original)
+++ wicket/trunk/wicket-core/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java Fri Jan 14 19:13:59 2011
@@ -337,11 +337,7 @@ public final class LocalizedImageResourc
 		}
 
 		// Set the SRC attribute to point to the component or shared resource
-		tag.put(
-			"src",
-			RequestCycle.get()
-				.getOriginalResponse()
-				.encodeURL(Strings.replaceAll(url, "&", "&amp;")));
+		tag.put("src", RequestCycle.get().getOriginalResponse().encodeURL(url));
 	}
 
 	/**