You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2019/07/24 22:17:44 UTC

[maven-surefire] 01/01: TLS 1.2 passed to maven-invoker-plugin via system property

This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a commit to branch TLS1.2
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git

commit 6425a679178d8ca73993d475eb800e82f4213900
Author: tibordigana <ti...@apache.org>
AuthorDate: Thu Jul 25 00:16:49 2019 +0200

    TLS 1.2 passed to maven-invoker-plugin via system property
---
 maven-failsafe-plugin/pom.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/maven-failsafe-plugin/pom.xml b/maven-failsafe-plugin/pom.xml
index 2e85275..2bc4a14 100644
--- a/maven-failsafe-plugin/pom.xml
+++ b/maven-failsafe-plugin/pom.xml
@@ -334,6 +334,7 @@
                                     <properties>
                                         <integration-test-port>${failsafe-integration-test-port}</integration-test-port>
                                         <integration-test-stop-port>${failsafe-integration-test-stop-port}</integration-test-stop-port>
+                                        <https.protocols>TLSv1.2</https.protocols>
                                     </properties>
                                 </configuration>
                             </execution>


Re: [maven-surefire] 01/01: TLS 1.2 passed to maven-invoker-plugin via system property

Posted by Tibor Digana <ti...@apache.org>.
Hi Robert,

Thx for hint. Perhaps you saw my branch.
That branch is only playground where I am testing our Jenkins.
Of course I will finish it as you have proposed with the configuration via
Jenkinsfile and system properties.
Additionally, the ITs have to use this system property too in their CLI
which is missing yet in my commit.

Cheers
Tibor

On Thu, Jul 25, 2019 at 8:23 AM Robert Scholte <rf...@apache.org> wrote:

> Please change
>
> <https.protocols>TLSv1.2</https.protocols>
>
> to
>
> <https.protocols>${https.protocols}</https.protocols>
>
> so it is only set when required, and we don't need to update the tests
> when there are new requirements for https protocols.
>
> thanks,
> Robert
>
> On Thu, 25 Jul 2019 00:17:44 +0200, <ti...@apache.org> wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > tibordigana pushed a commit to branch TLS1.2
> > in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
> >
> > commit 6425a679178d8ca73993d475eb800e82f4213900
> > Author: tibordigana <ti...@apache.org>
> > AuthorDate: Thu Jul 25 00:16:49 2019 +0200
> >
> >     TLS 1.2 passed to maven-invoker-plugin via system property
> > ---
> >  maven-failsafe-plugin/pom.xml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/maven-failsafe-plugin/pom.xml
> > b/maven-failsafe-plugin/pom.xml
> > index 2e85275..2bc4a14 100644
> > --- a/maven-failsafe-plugin/pom.xml
> > +++ b/maven-failsafe-plugin/pom.xml
> > @@ -334,6 +334,7 @@
> >                                      <properties>
> >
> <integration-test-port>${failsafe-integration-test-port}</integration-test-port>
> >
> <integration-test-stop-port>${failsafe-integration-test-stop-port}</integration-test-stop-port>
> > +
> > <https.protocols>TLSv1.2</https.protocols>
> >                                      </properties>
> >                                  </configuration>
> >                              </execution>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: [maven-surefire] 01/01: TLS 1.2 passed to maven-invoker-plugin via system property

Posted by Robert Scholte <rf...@apache.org>.
Please change

<https.protocols>TLSv1.2</https.protocols>

to

<https.protocols>${https.protocols}</https.protocols>

so it is only set when required, and we don't need to update the tests  
when there are new requirements for https protocols.

thanks,
Robert

On Thu, 25 Jul 2019 00:17:44 +0200, <ti...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> tibordigana pushed a commit to branch TLS1.2
> in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
>
> commit 6425a679178d8ca73993d475eb800e82f4213900
> Author: tibordigana <ti...@apache.org>
> AuthorDate: Thu Jul 25 00:16:49 2019 +0200
>
>     TLS 1.2 passed to maven-invoker-plugin via system property
> ---
>  maven-failsafe-plugin/pom.xml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/maven-failsafe-plugin/pom.xml  
> b/maven-failsafe-plugin/pom.xml
> index 2e85275..2bc4a14 100644
> --- a/maven-failsafe-plugin/pom.xml
> +++ b/maven-failsafe-plugin/pom.xml
> @@ -334,6 +334,7 @@
>                                      <properties>
>                                          <integration-test-port>${failsafe-integration-test-port}</integration-test-port>
>                                          <integration-test-stop-port>${failsafe-integration-test-stop-port}</integration-test-stop-port>
> +                                         
> <https.protocols>TLSv1.2</https.protocols>
>                                      </properties>
>                                  </configuration>
>                              </execution>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org