You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/03/25 22:45:51 UTC
Review Request 57934: Issue while loading pig view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57934/
-----------------------------------------------------------
Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20572
https://issues.apache.org/jira/browse/AMBARI-20572
Repository: ambari
Description
-------
Pig view loading throws javascript error saying "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode".
Added strict mode in files where the error is being thrown.
Diffs
-----
contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js b0fa99e
contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 7d34edd
Diff: https://reviews.apache.org/r/57934/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 57934: Issue while loading pig view
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57934/#review170108
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 25, 2017, 10:45 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57934/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 10:45 p.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20572
> https://issues.apache.org/jira/browse/AMBARI-20572
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig view loading throws javascript error saying "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode".
>
> Added strict mode in files where the error is being thrown.
>
>
> Diffs
> -----
>
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js b0fa99e
> contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 7d34edd
>
>
> Diff: https://reviews.apache.org/r/57934/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57934: Issue while loading pig view
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57934/#review170136
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On March 25, 2017, 10:45 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57934/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 10:45 p.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20572
> https://issues.apache.org/jira/browse/AMBARI-20572
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig view loading throws javascript error saying "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode".
>
> Added strict mode in files where the error is being thrown.
>
>
> Diffs
> -----
>
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js b0fa99e
> contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 7d34edd
>
>
> Diff: https://reviews.apache.org/r/57934/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 57934: Issue while loading pig view
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57934/#review170107
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 25, 2017, 10:45 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57934/
> -----------------------------------------------------------
>
> (Updated March 25, 2017, 10:45 p.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20572
> https://issues.apache.org/jira/browse/AMBARI-20572
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Pig view loading throws javascript error saying "Block-scoped declarations (let, const, function, class) not yet supported outside strict mode".
>
> Added strict mode in files where the error is being thrown.
>
>
> Diffs
> -----
>
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/splash.js b0fa99e
> contrib/views/pig/src/main/resources/ui/pig-web/app/routes/splash.js 7d34edd
>
>
> Diff: https://reviews.apache.org/r/57934/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>