[jira] [Updated] (DBCP-462) Refactoring of PStmtKey and PoolingConnection

["KeiichiFujino (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

KeiichiFujino updated DBCP-462:
-------------------------------
    Attachment: PStmtKey.txt
                PoolingConnection.txt

Patch for PoolingConnection and PStmtKey

> Refactoring of PStmtKey and PoolingConnection
> ---------------------------------------------
>
>                 Key: DBCP-462
>                 URL: https://issues.apache.org/jira/browse/DBCP-462
>             Project: Commons Dbcp
>          Issue Type: Improvement
>    Affects Versions: 2.1.1
>            Reporter: KeiichiFujino
>            Priority: Minor
>         Attachments: PStmtKey.txt, PoolingConnection.txt
>
>
> In PoolingConnection, the following methods are not defined.
> -prepareStatement(String sql, int[] columnIndexes) 
> -prepareStatement(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability) 
> -prepareStatement(String sql, String[] columnNames) 
> -prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability) 
> Therefore, when calling these methods, we can not cache statements.
> I had tried to implement these methods in PoolingConnection.
> However, because the code in the PoolingConnection#makeObject is a little complex,
> I thought that it is difficult to add new conditions.
> So, in order to more easily implement the Connection#prepareStatement that are not defined in the PoolingConnection, 
> I did a refactoring for the PStmtKey and PoolingConnection.
> If these refactoring are accepted,I have a plan to implement the following methods to PoolingConnection 
> in order to cache all of Prepared or Callable Statement.
> -prepareStatement(String sql, int[] columnIndexes) 
> -prepareStatement(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability) 
> -prepareStatement(String sql, String[] columnNames) 
> -prepareCall(String sql, int resultSetType, int resultSetConcurrency, int resultSetHoldability) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)