[jira] [Commented] (DOXIA-724) Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806269#comment-17806269 ] 

Konrad Windszus commented on DOXIA-724:
---------------------------------------

There are multiple bugs in the implementation:
# The order of the {{PriorityQueue.iterator()}} being used in the for each loop does not guarantee any order (https://docs.oracle.com/javase/8/docs/api/java/util/PriorityQueue.html#iterator--)
# The method getWrappedSink() orders the pipeline in the reverse order being returned by 1. 

> Sink pipeline returned by AbstractParser.getWrappedSink(...) has wrong order
> ----------------------------------------------------------------------------
>
>                 Key: DOXIA-724
>                 URL: https://issues.apache.org/jira/browse/DOXIA-724
>             Project: Maven Doxia
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M9
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> According to the javadoc the SinkWrapperFactory should be ordered according to their priority from highest to lowest. However in {{AbstractParser.getWrappedSink()}} a pipeline is returned which is ordered the other way around (i.e. lowest priority first).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)