You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/02/17 10:32:37 UTC

[GitHub] spark pull request: SPARK-5841 [CORE] [HOTFIX] Memory leak in Disk...

GitHub user srowen opened a pull request:

    https://github.com/apache/spark/pull/4648

    SPARK-5841 [CORE] [HOTFIX] Memory leak in DiskBlockManager	

    Avoid call to remove shutdown hook being called from shutdown hook
    
    CC @pwendell @JoshRosen @MattWhelan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/spark SPARK-5841.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4648
    
----
commit 51548dbe1d58b74aeda29086c4e75a7120dfb53d
Author: Sean Owen <so...@cloudera.com>
Date:   2015-02-17T09:31:18Z

    Avoid call to remove shutdown hook being called from shutdown hook

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-5841 [CORE] [HOTFIX] Memory leak in Disk...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4648#issuecomment-74640475
  
      [Test build #27627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27627/consoleFull) for   PR 4648 at commit [`51548db`](https://github.com/apache/spark/commit/51548dbe1d58b74aeda29086c4e75a7120dfb53d).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-5841 [CORE] [HOTFIX] Memory leak in Disk...

Posted by MattWhelan <gi...@git.apache.org>.
Github user MattWhelan commented on the pull request:

    https://github.com/apache/spark/pull/4648#issuecomment-74711906
  
    LGTM.  Thanks for taking care of this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-5841 [CORE] [HOTFIX] Memory leak in Disk...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/4648#issuecomment-74650245
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27627/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-5841 [CORE] [HOTFIX] Memory leak in Disk...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/4648#issuecomment-74650240
  
      [Test build #27627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27627/consoleFull) for   PR 4648 at commit [`51548db`](https://github.com/apache/spark/commit/51548dbe1d58b74aeda29086c4e75a7120dfb53d).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-5841 [CORE] [HOTFIX] Memory leak in Disk...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/4648


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org