You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/02/11 00:06:10 UTC

[GitHub] nifi issue #1497: NIFI-3454 Tests should consistently use the FileNameFilter...

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1497
  
    @ottobackwards Reviewed the changes. Confirmed that both test runs successfully even if there's a .DS_Store file in the test input directory. +1
    
    Please note that when you submit a PR for a JIRA, push the "submit patch" button to move JIRA status forward to "Patch Available". This ensure other developers to know it's ready for PR.
    
    ![image](https://cloud.githubusercontent.com/assets/1107620/22848562/c879703c-f038-11e6-89b2-55fc3d7d0d7c.png)
    
    https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess
    
    I'm going to merge this. Thank you for you contributing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---