You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/10/08 14:21:54 UTC
[PR] chore: remove stale Akka-era references from Scaladoc and a log message [pekko]
pjfanning opened a new pull request, #3584:
URL: https://github.com/apache/pekko/pull/3584
### Motivation
Some Scaladoc and one log message still refer to Akka-era details that are misleading for Pekko users. These were left out of #3583 because they are in source files.
### Modification
- `RemoveInternalClusterShardingData`: drop the `-2.3` flag (for data written by Akka 2.3.x) from the usage example and description, and no longer mention auto-down as a cause of corrupt data. The flag handling in `main` is unchanged.
- `Cluster`: the auto-down warning now says auto-down is not supported in Pekko, instead of "auto-down has been removed in Akka 2.6.0".
- `Sink.collection` Scaladoc: refer to the collection `Factory` instead of `CanBuildFrom`.
### Result
Scaladoc and the warning match Pekko.
### Tests
- Not run - Scaladoc and log message text only (no test asserts the warning text)
### References
Refs #3583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: remove stale Akka-era references from Scaladoc and a log message [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #3584:
URL: https://github.com/apache/pekko/pull/3584#issuecomment-6074857710
Pushed fe4bacf to restore the `-2.3` paragraph: the flag is still parsed (`args(0) == "-2.3"`) and `remove2dot3Data` is a parameter of the public `remove` API, so removing it should be one deliberate change across code, Scaladoc, docs and MiMa rather than a docs-only deletion. The auto-down message and the `Factory` fixes are good as they are. Will merge once CI is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: remove stale Akka-era references from Scaladoc and a log message [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #3584:
URL: https://github.com/apache/pekko/pull/3584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: remove stale Akka-era references from Scaladoc and a log message [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #3584:
URL: https://github.com/apache/pekko/pull/3584#discussion_r4226593243
##########
cluster-sharding/src/main/scala/org/apache/pekko/cluster/sharding/RemoveInternalClusterShardingData.scala:
##########
@@ -43,14 +43,14 @@ import pekko.persistence.journal.leveldb.SharedLeveldbStore
*
* It can be needed to remove the data if the Cluster `ShardCoordinator`
* cannot startup because of corrupt data, which may happen if accidentally
- * two clusters were running at the same time, e.g. caused by using auto-down
- * and there was a network partition.
+ * two clusters were running at the same time, e.g. caused by a network partition
+ * without a proper downing strategy.
*
* Use this program as a standalone Java main program:
* {{{
* java -classpath <jar files, including pekko-cluster-sharding>
* org.apache.pekko.cluster.sharding.RemoveInternalClusterShardingData
- * -2.3 entityType1 entityType2 entityType3
+ * entityType1 entityType2 entityType3
Review Comment:
The `-2.3` flag is still live: `args(0) == "-2.3"` at line 77, and `remove2dot3Data` is a parameter of the public `remove` method and of the public class constructor. `docs/src/main/paradox/typed/cluster-sharding.md:851` also still advertises `-2.3`. Deleting this paragraph removes the only in-source explanation of the flag and makes the Scaladoc example disagree with both the code and the published docs. Could you keep the paragraph (dropping it from the example is fine), or move the flag removal into a separate PR that also updates the code, the docs and the MiMa filters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org