You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/02/19 01:32:53 UTC

[GitHub] [cxf] reta commented on pull request #746: [CXF-8361] Finalized support for Jakarta NS

reta commented on pull request #746:
URL: https://github.com/apache/cxf/pull/746#issuecomment-781752057


   Thanks for the PR, @ropalka, I think we got to the point when it is probably make sense to completely separate Jakartaee and Javaee name handler chains (I think you would agree). I suggest to:
   1. Introduce `org.apache.cxf.jaxws.handler.jakartaee` and `org.apache.cxf.jaxws.handler.javaee`
   2. Introduce `JakartaeeHandlerChainBuilder` and `JavaeeHandlerChainBuilder`
   3. Basically, I think it safe to assume that either JakartaEE or JavaEE namespace is going to be used, so in this case `AnnotationHandlerChainBuilder` could inspect the namespace, instantiate  `JakartaeeHandlerChainBuilder` or`JavaeeHandlerChainBuilder`, and delegate to one of those. In this case, the conditionals should be gone and implementation becomes much cleaner. 
   
   What do you think? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org