You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2024/05/13 18:32:53 UTC

[PR] [Test only] Run validation on Flink 1.17 [beam]

Abacn opened a new pull request, #31274:
URL: https://github.com/apache/beam/pull/31274

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2116901429

   https://github.com/apache/beam/pull/31328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2109041402

   Run Python_Coverage PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2110493396

   The test entry is here: https://github.com/apache/beam/blob/master/release/src/main/groovy/quickstart-java-flinklocal.groovy
   
   One can see the invocation only has "--runner=FlinkRunner -Pflink-runner" parameter. The first tells beam to use Flink runner, the second tells maven to activate flink related java dependencies, which pinned to "project.ext.latestFlinkVersion":
   
   https://github.com/apache/beam/blob/c1d1bd642d152f05ff5bcf64b4630e059c681ba7/sdks/java/maven-archetypes/examples/build.gradle#L50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2109042735

   ## Test Results
   0 files   -    10  0 suites   - 10   0s :stopwatch: - 23m 15s
   0 tests  - 7 539  0 :white_check_mark:  - 6 641  0 :zzz:  -   898  0 :x: ±0 
   0 runs   - 7 737  0 :white_check_mark:  - 6 670  0 :zzz:  - 1 067  0 :x: ±0 
   
   Results for commit 0542c83f. ± Comparison against base commit c230655a.
   
   [test-results]:data:application/gzip;base64,H4sIAAKuQmYC/1WMyw7CIBBFf6Vh7WIoYsGfMThAMrEthsfK+O82tdFhd8+5yXmJSHMo4jrAaRClUf2Bb9lVSuuB21EL37fSEHvxoGcnoqO5EyHnlA+T21rY5Lkv/2s7s9jOvIVpWahuIECfRzQqonSjslZPwcgJ7lYFrzUA4sWAkc6L9wec88Zf+wAAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2109038988

   LGTM once all testing is passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #31274:
URL: https://github.com/apache/beam/pull/31274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Test only] Run validation on Flink 1.17 [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2108574449

   `./gradlew :runners:flink:1.17:runQuickstartJavaFlinkLocal` now also failing: https://github.com/apache/beam/actions/runs/9068053305/job/24914468708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Test only] Run validation on Flink 1.17 [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2108650107

   Running a Nightly Snapshot on this branch: https://github.com/apache/beam/actions/runs/9068716106
   
   then will run a PostRelease test to see if revert two PRs will fix PostRelease test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2108751602

   I have cleaned up this test PR and ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2110500379

   Two possible way to fix
   
   - Move createJavaExamplesArchetypeValidationTask from flink_runner.gradle to runners/flink/build.gradle, so a single validation task run on latest supported flink
   
   - make createJavaExamplesArchetypeValidationTask aware of flink version, pass it down to maven-archetype project, and set version there


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2109040299

   Also adding @thebozzcl and @je-ik for awareness.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2108798997

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2109660677

   This exposes a separate issue that Flink 1.18 class (presumably the highest supported one) is used when running the Flink 1.17 QuickStart test. This makes the trat now failing in both 1.18 and 1.17 version and confused us


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert Flink 1.18 support [beam]

Posted by "je-ik (via GitHub)" <gi...@apache.org>.
je-ik commented on PR #31274:
URL: https://github.com/apache/beam/pull/31274#issuecomment-2116899076

   The check passes on current master. After reverting this PR the test for Flink 1.18 pass locally. I'm not familiar with the mechanics how the test is executed, though. It uses maven, but I'm unable to get the `pom.xml` used to execute the test to compare it for differences with 1.17. Any clues anyone?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org