You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2016/06/24 07:05:26 UTC
[48/50] kylin git commit: fix RealizationRegistry related tests
fix RealizationRegistry related tests
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/dd1fea3f
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/dd1fea3f
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/dd1fea3f
Branch: refs/heads/stream_m1
Commit: dd1fea3f5dadfa0b2ce74d6bfcef925174b19998
Parents: 842f590
Author: Li Yang <li...@apache.org>
Authored: Fri Jun 24 09:46:25 2016 +0800
Committer: Li Yang <li...@apache.org>
Committed: Fri Jun 24 10:55:42 2016 +0800
----------------------------------------------------------------------
.../metadata/realization/RealizationRegistry.java | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/dd1fea3f/core-metadata/src/main/java/org/apache/kylin/metadata/realization/RealizationRegistry.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/realization/RealizationRegistry.java b/core-metadata/src/main/java/org/apache/kylin/metadata/realization/RealizationRegistry.java
index b447531..e6b1a86 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/realization/RealizationRegistry.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/realization/RealizationRegistry.java
@@ -20,7 +20,6 @@ package org.apache.kylin.metadata.realization;
import java.io.IOException;
import java.util.Collections;
-import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
@@ -30,7 +29,6 @@ import org.apache.kylin.common.util.ClassUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
/**
@@ -84,7 +82,6 @@ public class RealizationRegistry {
// use reflection to load providers
String[] providerNames = config.getRealizationProviders();
- List<Throwable> es = Lists.newArrayList();
for (String clsName : providerNames) {
try {
Class<? extends IRealizationProvider> cls = ClassUtil.forName(clsName, IRealizationProvider.class);
@@ -92,17 +89,16 @@ public class RealizationRegistry {
providers.put(p.getRealizationType(), p);
} catch (Exception | NoClassDefFoundError e) {
- es.add(e);
- }
-
- if (es.size() > 0) {
- for (Throwable exceptionOrError : es) {
- logger.error("Create new store instance failed ", exceptionOrError);
- }
- throw new IllegalArgumentException("Failed to find metadata store by url: " + config.getMetadataUrl());
+ if (e instanceof ClassNotFoundException || e instanceof NoClassDefFoundError)
+ logger.warn("Failed to create realization provider " + e);
+ else
+ logger.error("Failed to create realization provider", e);
}
}
+ if (providers.isEmpty())
+ throw new IllegalArgumentException("Failed to find realization provider by url: " + config.getMetadataUrl());
+
logger.info("RealizationRegistry is " + providers);
}