You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/10/19 12:47:22 UTC
[PR] Use prevEndRow from Extent in ConditionalTabletMutator [accumulo]
dlmarion opened a new pull request, #3870:
URL: https://github.com/apache/accumulo/pull/3870
Fixes #3356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use prevEndRow from Extent in ConditionalTabletMutator [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3870:
URL: https://github.com/apache/accumulo/pull/3870#issuecomment-1771088502
Errorprone failure is due to an issue in the `elasticity` branch, not this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use prevEndRow from Extent in ConditionalTabletMutator [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3870:
URL: https://github.com/apache/accumulo/pull/3870#discussion_r1365636163
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/ConditionalTabletMutatorImpl.java:
##########
@@ -251,6 +241,12 @@ public Ample.ConditionalTabletMutator requireSame(TabletMetadata tabletMetadata,
public void submit(Ample.RejectionHandler rejectionCheck) {
Preconditions.checkState(updatesEnabled, "Cannot make updates after calling mutate.");
Preconditions.checkState(sawOperationRequirement, "No operation requirements were seen");
+ if (checkPrevEndRow && extent.prevEndRow() != null) {
Review Comment:
Need to check the prevEndRow when its null. The `encodePrevEndRow()` method handles null and is what is used to serialize the prev end row for writes.
```suggestion
if (checkPrevEndRow) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use prevEndRow from Extent in ConditionalTabletMutator [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #3870:
URL: https://github.com/apache/accumulo/pull/3870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org