You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/25 06:29:45 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #10672:
[FLINK-15373][core][config] Update descriptions for framework / task
off-heap memory config options
zhuzhurk commented on a change in pull request #10672: [FLINK-15373][core][config] Update descriptions for framework / task off-heap memory config options
URL: https://github.com/apache/flink/pull/10672#discussion_r361264512
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -275,8 +276,9 @@
public static final ConfigOption<String> TASK_OFF_HEAP_MEMORY =
key("taskmanager.memory.task.off-heap.size")
.defaultValue("0b")
- .withDescription("Task Heap Memory size for TaskExecutors. This is the size of off heap memory (JVM direct"
- + " memory or native memory) reserved for user code.");
+ .withDescription("Task Off-Heap Memory size for TaskExecutors. This is the size of off heap memory (JVM"
+ + " direct memory and native memory) reserved for user code. The configured value will be fully counted"
Review comment:
I think it should be `for tasks` rather than `for user code`, e.g. it can be used by Flink sql operators or state backends.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services