You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/08/03 16:44:44 UTC
Re: Review Request 36908: Added QuotaInfo Protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93908
-----------------------------------------------------------
include/mesos/master/quota.proto (line 25)
<https://reviews.apache.org/r/36908/#comment148337>
If the guaranteed resource allocation is ALL that QuotaInfo describes, we should rename it. However, reading on, it seems to me that we want QuotaInfo to describe both the minimum AND the limit in the long run. So this should be pointed out right here. The TODO further below comes a bit too late IMHO.
include/mesos/master/quota.proto (line 34)
<https://reviews.apache.org/r/36908/#comment148339>
s/should/must
s/Resource.role/guaranteed.role
s/QuotaInfo.role/the above role
include/mesos/master/quota.proto (line 36)
<https://reviews.apache.org/r/36908/#comment148340>
s/guaranteed/guarantees
include/mesos/master/quota.proto (line 38)
<https://reviews.apache.org/r/36908/#comment148341>
limit, bound -> plural
- Bernd Mathiske
On July 29, 2015, 9:59 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 9:59 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added QuotaInfo Protobuf.
>
>
> Diffs
> -----
>
> include/mesos/master/quota.hpp PRE-CREATION
> include/mesos/master/quota.proto PRE-CREATION
> src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332
>
> Diff: https://reviews.apache.org/r/36908/diff/
>
>
> Testing
> -------
>
> make distcheck
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36908: Added QuotaInfo Protobuf.
Posted by Till Toenshoff <to...@me.com>.
> On Aug. 3, 2015, 2:44 p.m., Bernd Mathiske wrote:
> > include/mesos/master/quota.proto, line 38
> > <https://reviews.apache.org/r/36908/diff/2/?file=1024652#file1024652line38>
> >
> > limit, bound -> plural
I would suggest to reword:
"Add upper bounds limit of resources that ..."
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93908
-----------------------------------------------------------
On July 29, 2015, 4:59 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 4:59 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added QuotaInfo Protobuf.
>
>
> Diffs
> -----
>
> include/mesos/master/quota.hpp PRE-CREATION
> include/mesos/master/quota.proto PRE-CREATION
> src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332
>
> Diff: https://reviews.apache.org/r/36908/diff/
>
>
> Testing
> -------
>
> make distcheck
>
>
> Thanks,
>
> Joerg Schad
>
>