[GitHub] [netbeans] dbalek commented on a change in pull request #3123: LSP: Move refactoring added.

[GitBox <gi...@apache.org>]

dbalek commented on a change in pull request #3123:
URL: https://github.com/apache/netbeans/pull/3123#discussion_r696018841



##########
File path: ide/refactoring.api/src/org/netbeans/modules/refactoring/plugins/FileMovePlugin.java
##########
@@ -80,7 +80,7 @@ public Problem checkParameters() {
     public void cancelRequest() {
     }
     
-    private class MoveFile extends SimpleRefactoringElementImplementation {
+    public class MoveFile extends SimpleRefactoringElementImplementation {

Review comment:
       Is the API change note really necessary for a class in a NON public package? It is used in an `instanceof` check inside `MoveRefactoring.move(...)` method. However, the `instancof` could be avoided if you insist on it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists