You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by is...@cocoondev.org on 2005/05/17 16:44:55 UTC

[JIRA] Created: (FOR-499) Modiications to the Eclipse Plugin for Forrest

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-499

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-499
    Summary: Modiications to the Eclipse Plugin for Forrest
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Tool: Eclipse config
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Anil Ramnanan

    Created: Tue, 17 May 2005 9:44 AM
    Updated: Tue, 17 May 2005 9:44 AM

Description:
This patch includes two fixes:

1. It prevents the user from starting more than one instance of the live server

2. It waits until the server is loaded before it opens the web browser.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Updated: (FOR-499) Modiications to the Eclipse Plugin for Forrest

Posted by is...@cocoondev.org.
The following issue has been updated:

    Updater: Anil Ramnanan (mailto:anil@peppersauce.org)
       Date: Tue, 17 May 2005 9:45 AM
    Changes:
             Attachment changed to forrestPatch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.cocoondev.org//browse/FOR-499?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-499

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-499
    Summary: Modiications to the Eclipse Plugin for Forrest
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Tool: Eclipse config
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Anil Ramnanan

    Created: Tue, 17 May 2005 9:44 AM
    Updated: Tue, 17 May 2005 9:45 AM

Description:
This patch includes two fixes:

1. It prevents the user from starting more than one instance of the live server

2. It waits until the server is loaded before it opens the web browser.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Updated: (FOR-499) Better server starting in Eclipse plugin

Posted by is...@cocoondev.org.
The following issue has been updated:

    Updater: Ross Gardler (mailto:ross@saafe.org)
       Date: Tue, 17 May 2005 2:49 PM
    Changes:
             summary changed from Modiications to the Eclipse Plugin for Forrest to Better server starting in Eclipse plugin
             Fix Version changed to 0.8
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.cocoondev.org//browse/FOR-499?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-499

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-499
    Summary: Better server starting in Eclipse plugin
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Tool: Eclipse config
   Fix Fors:
             0.8
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Anil Ramnanan

    Created: Tue, 17 May 2005 9:44 AM
    Updated: Tue, 17 May 2005 2:49 PM

Description:
This patch includes two fixes:

1. It prevents the user from starting more than one instance of the live server

2. It waits until the server is loaded before it opens the web browser.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Closed: (FOR-499) Better server starting in Eclipse plugin

Posted by is...@cocoondev.org.
Message:

   The following issue has been closed.

   Resolver: Ross Gardler
       Date: Tue, 17 May 2005 4:46 PM

Actually, on second thoughts I've applied with modifications:

I realised since the location of jettyconf is hard coded as well it is unlikely that people will be using a different port (we do not currently support custom jettyconf.xml files). I therefore replaced your hard coded port numbers with a variable and added a FIXME note to get this port number from the plugin preferences.

I've made the thread sleep for a while between checks on the port, this will prevent the thread from consuming too many resources whilst waiting for the server to finish starting.

I added a timeout to prevent going into an infinite loop if the server fails to start (or if someone has hacked the jettyconf.xml)

I took the opportunity to improve the error reporting now that you have provided more places to check the status of the startup.

Let me know if you see any problems with my changes to your patch. Thanks for the contribution.
---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-499

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-499
    Summary: Better server starting in Eclipse plugin
       Type: Improvement

     Status: Closed
   Priority: Minor
 Resolution: FIXED

    Project: Forrest
 Components: 
             Tool: Eclipse config
   Fix Fors:
             0.7-dev
   Versions:
             0.7-dev

   Assignee: Ross Gardler
   Reporter: Anil Ramnanan

    Created: Tue, 17 May 2005 9:44 AM
    Updated: Tue, 17 May 2005 4:46 PM

Description:
This patch includes two fixes:

1. It prevents the user from starting more than one instance of the live server

2. It waits until the server is loaded before it opens the web browser.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Commented: (FOR-499) Modiications to the Eclipse Plugin for Forrest

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Ross Gardler
    Created: Tue, 17 May 2005 2:47 PM
       Body:
I've not applied this patch as there are a couple of problems with it, when I have the time I'll resolve these problems and apply. If you beat me to it then even better ;-):

a) The port number is hard coded into the application, since the user can change the port number in the jettyconf.xml file this could result in the server never starting. We need to retrieve the port number from the jettyconf file.

b) The method used for waiting for the server to start could go into an endless loop if the server failed to start for some reason. I suggest putting a time out limit on the while loop so that if the server has not started after a given amount of time then an exception is thrown.

Thanks for your contribution, we'll apply soon.
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-499?page=comments#action_12402

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-499

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-499
    Summary: Modiications to the Eclipse Plugin for Forrest
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Tool: Eclipse config
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Anil Ramnanan

    Created: Tue, 17 May 2005 9:44 AM
    Updated: Tue, 17 May 2005 2:47 PM

Description:
This patch includes two fixes:

1. It prevents the user from starting more than one instance of the live server

2. It waits until the server is loaded before it opens the web browser.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira