You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/15 06:35:55 UTC

[GitHub] feng-tao commented on issue #4322: [AIRFLOW-3518] Performance fixes for topological_sort

feng-tao commented on issue #4322: [AIRFLOW-3518] Performance fixes for topological_sort
URL: https://github.com/apache/incubator-airflow/pull/4322#issuecomment-447542271
 
 
   @ashb , I think whether to compare dag_id or not doesn't seem to matter that much.  From the code, if  ```self.task_id == other.task_id and  (type(self) == type(other)```, it will still compare all the attributes for the operator which implictly checks dag_id as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services