You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2015/04/29 12:45:15 UTC
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/559
TAJO-1584: Remove QueryMaster client sharing in TajoMaster and TajoWorke...
...r
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-1584
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/559.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #559
----
commit 2c138e53e2e61617ef5797d5dbb88791b24de746
Author: Jinho Kim <jh...@apache.org>
Date: 2015-04-29T10:43:30Z
TAJO-1584: Remove QueryMaster client sharing in TajoMaster and TajoWorker
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/559#issuecomment-97386990
I’ve add option to reuse configuration.
QUERY_MASTER_RPC_CLIENT_REUSE("tajo.querymaster.rpc.client.reuse", false)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/559#discussion_r29414552
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java ---
@@ -156,8 +161,15 @@ public boolean startQueryMaster() {
private void connectQueryMaster() throws Exception {
InetSocketAddress addr = NetUtils.createSocketAddr(queryInfo.getQueryMasterHost(), queryInfo.getQueryMasterPort());
LOG.info("Connect to QueryMaster:" + addr);
- queryMasterRpc =
- RpcClientManager.getInstance().getClient(addr, QueryMasterProtocol.class, true);
+
+ /* A large scale cluster can be connection refused, if it reuse */
--- End diff --
It would be better if it should be changed to 'Connection can be refused in large scale clusters if 'reuse' option is TRUE'.
In addition, this description should be also described in ```QUERY_MASTER_RPC_CLIENT_REUSE``` in TajoConf and user guide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/559#issuecomment-99389833
+1 ship it!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/559#issuecomment-99299271
@hyunsik
Could you review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/559#issuecomment-97722324
In this patch, the connection reuse is changed to be optional. In my opinion, it would be better if we completely remove the reuse feature. Actually, I'm not sure if anyone want 'reuse feature'.
Others look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1584: Remove QueryMaster client sharing in...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/559#issuecomment-97725375
I agree with you. I will remove the 'reuse feature'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---