You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/03 10:18:39 UTC
[GitHub] [hudi] t0il3ts0ap opened a new pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
t0il3ts0ap opened a new pull request #4741:
URL: https://github.com/apache/hudi/pull/4741
…rics
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
As of now all metrics created by hudi has table name prefixed by default. This pr aims to put that behavior behind a configuration and allows the user to disable it.
For example lets say we have 2 hudi tabls customers and loan_accounts. Right now the metrics in prometheus will come like this
```
customers_TimelineService_TOTAL_HANDLE_TIME{instance="",job="customers"} 589
loan_accounts_TimelineService_TOTAL_HANDLE_TIME{instance="",job="loan_accounts"} 642
```
Its conventional in prometheus to have consistent metric name with differences in labels. After the changes in this pr, metrics will come like this which is much simpler to plot across lets say 100s of hudi tables with each having 100s of metrics.
```
TimelineService_TOTAL_HANDLE_TIME{job="customers"} 589
TimelineService_TOTAL_HANDLE_TIME{job="loan_accounts"} 642
```
## Brief change log
Added configuration `hoodie.metrics.common_prefix.enable`
This configuration is true by default and which doesnt change any behavior for existing users.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1029608015
@rmahindra123 : can you review this patch please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#discussion_r798534340
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java
##########
@@ -84,6 +84,13 @@
.sinceVersion("0.7.0")
.withDocumentation("");
+ public static final ConfigProperty<Boolean> ENABLE_COMMON_PREFIX = ConfigProperty
+ .key(METRIC_PREFIX + ".common_prefix.enable")
+ .defaultValue(true)
+ .sinceVersion("0.10.0")
Review comment:
version should be 0.11.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1028837130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "347641d0cef968cb368ec7ebd073316026a82af7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5702",
"triggerID" : "347641d0cef968cb368ec7ebd073316026a82af7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 347641d0cef968cb368ec7ebd073316026a82af7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5702)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] t0il3ts0ap commented on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
t0il3ts0ap commented on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1029646380
Closing this as could use #4274.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1028837130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "347641d0cef968cb368ec7ebd073316026a82af7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5702",
"triggerID" : "347641d0cef968cb368ec7ebd073316026a82af7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 347641d0cef968cb368ec7ebd073316026a82af7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5702)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1028834445
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "347641d0cef968cb368ec7ebd073316026a82af7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "347641d0cef968cb368ec7ebd073316026a82af7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 347641d0cef968cb368ec7ebd073316026a82af7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1028884413
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "347641d0cef968cb368ec7ebd073316026a82af7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5702",
"triggerID" : "347641d0cef968cb368ec7ebd073316026a82af7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 347641d0cef968cb368ec7ebd073316026a82af7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5702)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rmahindra123 commented on a change in pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
rmahindra123 commented on a change in pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#discussion_r799142506
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1561,6 +1561,10 @@ public boolean isExecutorMetricsEnabled() {
getStringOrDefault(HoodieMetricsConfig.EXECUTOR_METRICS_ENABLE, "false"));
}
+ public boolean isMetricsCommonPrefixEnabled() {
Review comment:
Why do you need another config. Check this PR: https://github.com/apache/hudi/pull/4274/files. If you want remove the infer function for METRICS_REPORTER_PREFIX, so it does not use the table name as default and the user can set a prefix using METRICS_REPORTER_PREFIX. Does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] t0il3ts0ap closed pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
t0il3ts0ap closed pull request #4741:
URL: https://github.com/apache/hudi/pull/4741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#issuecomment-1028834445
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "347641d0cef968cb368ec7ebd073316026a82af7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "347641d0cef968cb368ec7ebd073316026a82af7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 347641d0cef968cb368ec7ebd073316026a82af7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] t0il3ts0ap commented on a change in pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
t0il3ts0ap commented on a change in pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#discussion_r799171059
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1561,6 +1561,10 @@ public boolean isExecutorMetricsEnabled() {
getStringOrDefault(HoodieMetricsConfig.EXECUTOR_METRICS_ENABLE, "false"));
}
+ public boolean isMetricsCommonPrefixEnabled() {
Review comment:
Ohh, I didnt notice while rebasing changes. I think I can use #4274. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rmahindra123 commented on a change in pull request #4741: [MINOR] Add configuration to enable/disable common prefix for all met…
Posted by GitBox <gi...@apache.org>.
rmahindra123 commented on a change in pull request #4741:
URL: https://github.com/apache/hudi/pull/4741#discussion_r799191969
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1561,6 +1561,10 @@ public boolean isExecutorMetricsEnabled() {
getStringOrDefault(HoodieMetricsConfig.EXECUTOR_METRICS_ENABLE, "false"));
}
+ public boolean isMetricsCommonPrefixEnabled() {
Review comment:
No problem. Thanks @t0il3ts0ap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org