You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/03 20:58:08 UTC
[GitHub] [beam] Abacn opened a new pull request, #23027: Assert pipeline results in performance tests
Abacn opened a new pull request, #23027:
URL: https://github.com/apache/beam/pull/23027
Fixes #23026
* Fix possible false possitive test status
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236213119
Run Java MongoDBIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212998
Run Java ParquetIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212935
Run BigQueryIO Batch Performance Test Java Json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1240998262
The two failed tests: SQL BigQueryIO is already perma-red; KafkaIO is failed "correctly" and would be fixed seperately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236213088
Run Java HadoopFormatIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236213014
Run Java TextIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212817
Run SQLBigQueryIO Batch Performance Test Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236213034
Run Java TFRecordIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212919
Run BigQueryIO Batch Performance Test Java Avro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236213055
Run Java XmlIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #23027:
URL: https://github.com/apache/beam/pull/23027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212974
Run Java AvroIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236216507
Kafka IO performance test has "failed correctly", previous success prior to https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_Kafka_IO/3005 was false positive [runs between run 3006 to 3026 there was another cause of failure (#23020)].
That is, the pipeline always fails with the following log message but previously not detected as fail test:
```
SEVERE: 2022-08-29T13:06:00.196Z: Workflow failed. Causes: S01:Generate records+Measure write time+Write to Kafka/Kafka ProducerRecord/Map+Write to Kafka/KafkaIO.WriteRecords/ParDo(KafkaWriter) failed., The job failed because a work item has failed 4 times.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1240800841
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1242214060
Gotcha. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212663
Run Java KafkaIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
bvolpato commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236346873
Just curious, can the job end with another terminal state other than DONE or FAILED? e.g., ran in a Runner that supports cancellation.
If so, we could expect for DONE explicitly, instead of checking for not FAILED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1242332957
Run Java_Examples_Dataflow_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1242191422
Kafka Performance test is running two exact same pipelines (after a pipeline option removed in #14168). Removed one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1237522922
> Just curious, can the job end with another terminal state other than `DONE` or `FAILED`? e.g., if executed in a runner that supports cancellation.
>
> If so, we could expect for `DONE` explicitly, instead of checking for not `FAILED`.
Yes you are right, cancel is missed in this assertion. I thought about if assert DONE or assert not FAILED. There exists some streaming tests that set to cancel the pipeline after certain time (because streaming pipelines generally does not DONE by themself); For simplicity I add same assertions for all performance tests.
Yes if we investigate each tests, including cancel as failure sounds more accurate; even more accurate the test should be marked as Aborted because a cancellation is initiated outside of the pipeline execution and done by runner (e.g. someone cancelled the pipeline at Dataflow). I just did not go this far. Assert not FAIL should suffice for the testing of Beam SDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236201731
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212952
Run Java CdapIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23027: Assert pipeline results in performance tests
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23027:
URL: https://github.com/apache/beam/pull/23027#issuecomment-1236212679
Run Java JdbcIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org