You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2007/10/22 03:05:20 UTC
[PATCH] Respect CPPFLAGS in Perl bindings
CPPFLAGS are respected everywhere except for Perl bindings.
It can be easily fixed without any side effects.
[[[
Respect CPPFLAGS in Perl bindings.
* subversion/bindings/swig/perl/native/Makefile.PL.in: Set cppflags to CPPFLAGS, and use cppflags in config.
Patch by: arfrever
]]]
Can I commit this patch?
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Respect CPPFLAGS in Perl bindings
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2007-10-22 07:50:22 Daniel L. Rall napisał(a):
> On Sun, 21 Oct 2007, Robert Spier wrote:
>
> > > Why is this necessary? For C++ compilers used against the native code in
> > > the Perl bindings? (If that's necessary, I'm in favor of this patch.)
> >
> > CPP in this context is "C pre-processor" not C++. In theory, CPPFLAGS
> > is where you specify -I and -D flags.
> >
> > CCFLAGS is generaly for the C compiler.
> > CXXFLAGS is generally for a C++ compiler.
>
> I've confirmed that we're using the variables as described by Robert.
> The preprocessors for Both C and C++ compilers are going to use CPPFLAGS,
> so it seems we need this patch.
Committed in r27304.
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Respect CPPFLAGS in Perl bindings
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Sun, 21 Oct 2007, Robert Spier wrote:
> > Why is this necessary? For C++ compilers used against the native code in
> > the Perl bindings? (If that's necessary, I'm in favor of this patch.)
>
> CPP in this context is "C pre-processor" not C++. In theory, CPPFLAGS
> is where you specify -I and -D flags.
>
> CCFLAGS is generaly for the C compiler.
> CXXFLAGS is generally for a C++ compiler.
I've confirmed that we're using the variables as described by Robert.
The preprocessors for Both C and C++ compilers are going to use CPPFLAGS,
so it seems we need this patch.
--
Daniel Rall
Re: [PATCH] Respect CPPFLAGS in Perl bindings
Posted by Robert Spier <rs...@pobox.com>.
> Why is this necessary? For C++ compilers used against the native code in
> the Perl bindings? (If that's necessary, I'm in favor of this patch.)
CPP in this context is "C pre-processor" not C++. In theory, CPPFLAGS
is where you specify -I and -D flags.
CCFLAGS is generaly for the C compiler.
CXXFLAGS is generally for a C++ compiler.
-R
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Respect CPPFLAGS in Perl bindings
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Mon, 22 Oct 2007, Arfrever Frehtes Taifersar Arahesis wrote:
> CPPFLAGS are respected everywhere except for Perl bindings.
> It can be easily fixed without any side effects.
>
> [[[
> Respect CPPFLAGS in Perl bindings.
>
> * subversion/bindings/swig/perl/native/Makefile.PL.in: Set cppflags to CPPFLAGS, and use cppflags in config.
>
> Patch by: arfrever
> ]]]
>
> Can I commit this patch?
Why is this necessary? For C++ compilers used against the native code in
the Perl bindings? (If that's necessary, I'm in favor of this patch.)
--
Daniel Rall