[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7546: Fix time-ordered scan queries on realtime segments

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #7546: Fix time-ordered scan queries on realtime segments
URL: https://github.com/apache/incubator-druid/pull/7546#discussion_r279077535
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/scan/ScanResultValue.java
 ##########
 @@ -105,6 +102,21 @@ public long getFirstEventTimestamp(ScanQuery.ResultFormat resultFormat)
     return singleEventScanResultValues;
   }
 
+  // If timestamp is < Integer.MAX_VALUE, it'll be an Integer object which can't be cast to a Long.  This method
+  // checks the type of the timestamp object and converts to a long value
+  private long convertTimestampObjectToLong(Object timestampObj)
 
 Review comment:
   This could use `DimensionHandlerUtils.convertObjectToLong()` instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org