You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/10/25 15:36:09 UTC
[GitHub] flink pull request #4904: [hotfix] reorder the methods so they conform to th...
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4904
[hotfix] reorder the methods so they conform to their order in the interface
## What is the purpose of the change
As discussed with @aljoscha in https://github.com/apache/flink/pull/4881, I'm moving those unmerged changes to this PR. The purpose is to reorder the impl methods so they conform to their order in the interface
## Brief change log
- reorder the impl methods
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4904
----
commit 7c16e92ca67f7d6fb59136ba908959d3deaef058
Author: Bowen Li <bo...@gmail.com>
Date: 2017-10-25T15:01:22Z
[hotfix] reorder the methods so they conform to the order in the interface
----
---
[GitHub] flink pull request #4904: [hotfix] reorder the methods so they conform to th...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/4904
---
[GitHub] flink issue #4904: [hotfix] reorder the methods so they conform to their ord...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4904
I merged, could you please close this PR? 👍
---
[GitHub] flink issue #4904: [hotfix] reorder the methods so they conform to their ord...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4904
```[INFO] ------------------------------------------------------------------------
[INFO] Building flink-streaming-java 1.4-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ flink-streaming-java_2.11 ---
[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (validate) @ flink-streaming-java_2.11 ---
[INFO] There is 1 error reported by Checkstyle 6.19 with /tools/maven/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/flink/streaming/api/operators/KeyedProcessOperator.java:[130] (regexp) RegexpSingleline: Trailing whitespace```
---