You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "lowka (via GitHub)" <gi...@apache.org> on 2023/07/26 04:06:23 UTC

[GitHub] [ignite-3] lowka commented on a diff in pull request #2343: IGNITE-19861: Introduce SQL metrics.

lowka commented on code in PR #2343:
URL: https://github.com/apache/ignite-3/pull/2343#discussion_r1274351473


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -385,6 +386,8 @@ private PartialNode startPartialNode(
 
         var indexManager = new IndexManager(tablesConfig, schemaManager, tableManager);
 
+        var metricManager = new MetricManager();

Review Comment:
   Why we do not use the existing MetricManager, defined in IgniteImpl?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org