You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2024/06/12 14:10:31 UTC
[PR] Add version to timestamp file [skywalking-banyandb]
hanahmily opened a new pull request, #468:
URL: https://github.com/apache/skywalking-banyandb/pull/468
### Fix querying old data points
A version column is introduced to each data point and stored in the timestamp file.
Even the file format is changed, the banyandb server has the capability to operate the previous files.
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12302.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add version to timestamp file [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on PR #468:
URL: https://github.com/apache/skywalking-banyandb/pull/468#issuecomment-2163981044
Noop
On Wed, Jun 12, 2024 at 22:40 吴晟 Wu Sheng ***@***.***> wrote:
> Is this resolving apache/skywalking#12255
> <https://github.com/apache/skywalking/issues/12255> as well?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/skywalking-banyandb/pull/468#issuecomment-2163190416>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAO6UWMQCOIAYSO2AP43LPLZHBMUPAVCNFSM6AAAAABJGOP3IGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGE4TANBRGY>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add version to timestamp file [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #468:
URL: https://github.com/apache/skywalking-banyandb/pull/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add version to timestamp file [skywalking-banyandb]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #468:
URL: https://github.com/apache/skywalking-banyandb/pull/468#issuecomment-2163190416
Is this resolving https://github.com/apache/skywalking/issues/12255 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org