You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/10 08:53:32 UTC

[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #12296: [Improvement][Test] Close static mock

EricGao888 opened a new issue, #12296:
URL: https://github.com/apache/dolphinscheduler/issues/12296

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   * In some UT cases, static mocks are not closed after used. This may cause unexpected UT failure. The best practice is to handle it with `try-with-resource`, see the code below for an example:
   
   https://github.com/apache/dolphinscheduler/blob/a973054950b3964d439597023e7f9471bbbf95fe/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/FileUtilsTest.java#L39-L43
   
   * related: #11405
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 closed issue #12296: [Improvement][Test] Close static mock

Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #12296: [Improvement][Test] Close static mock
URL: https://github.com/apache/dolphinscheduler/issues/12296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] rickchengx commented on issue #12296: [Improvement][Test] Close static mock

Posted by GitBox <gi...@apache.org>.
rickchengx commented on issue #12296:
URL: https://github.com/apache/dolphinscheduler/issues/12296#issuecomment-1272992330

   interested


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12296: [Improvement][Test] Close static mock

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12296:
URL: https://github.com/apache/dolphinscheduler/issues/12296#issuecomment-1273061344

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] EricGao888 commented on issue #12296: [Improvement][Test] Close static mock

Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12296:
URL: https://github.com/apache/dolphinscheduler/issues/12296#issuecomment-1272995515

   > interested
   
   Great, thx for help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org