You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/22 21:41:58 UTC
[GitHub] eric-haibin-lin closed pull request #8401: Make make lint compatible with python3 (don't call python2 explicitly)
eric-haibin-lin closed pull request #8401: Make make lint compatible with python3 (don't call python2 explicitly)
URL: https://github.com/apache/incubator-mxnet/pull/8401
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/Makefile b/Makefile
index 5d5dcdfc79..ceed645043 100644
--- a/Makefile
+++ b/Makefile
@@ -435,7 +435,7 @@ test: $(TEST)
lint: cpplint rcpplint jnilint pylint
cpplint:
- python2 dmlc-core/scripts/lint.py mxnet cpp include src plugin cpp-package tests \
+ dmlc-core/scripts/lint.py mxnet cpp include src plugin cpp-package tests \
--exclude_path src/operator/contrib/ctc_include
pylint:
@@ -467,7 +467,7 @@ cyclean:
# R related shortcuts
rcpplint:
- python2 dmlc-core/scripts/lint.py mxnet-rcpp ${LINT_LANG} R-package/src
+ dmlc-core/scripts/lint.py mxnet-rcpp ${LINT_LANG} R-package/src
rpkg:
mkdir -p R-package/inst
@@ -525,7 +525,7 @@ scaladeploy:
-Dlddeps="$(LIB_DEP) $(ROOTDIR)/lib/libmxnet.a")
jnilint:
- python2 dmlc-core/scripts/lint.py mxnet-jnicpp cpp scala-package/native/src
+ dmlc-core/scripts/lint.py mxnet-jnicpp cpp scala-package/native/src
ifneq ($(EXTRA_OPERATORS),)
clean: cyclean $(EXTRA_PACKAGES_CLEAN)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services