You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "svkcemk (via GitHub)" <gi...@apache.org> on 2023/02/01 05:41:52 UTC
[GitHub] [camel-quarkus] svkcemk opened a new pull request, #4465: #4051 : Add camel-cli-connector extension.
svkcemk opened a new pull request, #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092991663
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
let me try to fix I think I got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092868983
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
@svkcemk Please don't remove `qute.json` but just update the `version` in a new PR. Just curious how did you get this change, I think it should be included in the `Next is 2.17.0-SNAPSHOT` commit. see https://camel.apache.org/camel-quarkus/2.16.x/contributor-guide/release-guide.html#_next_version_in_camel_quarkus_main_branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1413334084
And the cli extension also ideally needs to scrape some details like done in SB (see also parent ticket)
https://github.com/apache/camel-spring-boot/blob/main/dsl-starter/camel-cli-connector-starter/src/main/java/org/apache/camel/springboot/cli/connector/CliConnectorAutoConfiguration.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092990398
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
sorry about it do you know how can I re-generate that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415139041
I'm not sure we can include this extension automatically in `DEV` mode.
@svkcemk I think the next step is to add a `BuildStep` in the deployment.
```
@BuildStep(onlyIf = IsCamelCliEnableOrIsDevelpment.class)
public void configureCli(MainClassBuildItem mainClass) {
// create QuarkusCliConnectorFactory
// you can get `RuntimeStartClass` for `MainClassBuildItem`
}
```
Free feel to create the following PR and we can work together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1168344733
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
Review Comment:
@svkcemk there is here another version to update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba closed pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba closed pull request #4465: #4051 : Add camel-cli-connector extension.
URL: https://github.com/apache/camel-quarkus/pull/4465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092995596
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
TBH, I don't know neither and let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093016628
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
Good, how did you get it work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1094164732
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-cli-connector</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: CLI Connector</name>
+ <description>Integration tests for Camel Quarkus CLI Connector extension</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-cli-connector</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+ <dependency>
Review Comment:
We add `camel-quarkus-management` here. Does it mean that user would need to add that each time in their own project ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415041609
@davsclaus Yes even we implemented it only in JVM mode/no native support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1516446035
rebase is not working, I did create this other one https://github.com/apache/camel-quarkus/pull/4812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415281798
> Thanks a lot @davsclaus for clarifying and I think https://camel.apache.org/manual/camel-jbang.html#_getting_status_of_camel_integrations is the case for running the application with `camel-quarkus-cli-connector`. We could expect to see the simiar output like:
>
> ```
> PID NAME CAMEL PLATFORM READY STATUS AGE TOTAL FAILED INFLIGHT SINCE-LAST
> 61818 MyCamel 3.20.0 Quarkus 2.17.0.Final 1/1 Running 28m34s 854 0 0 0s/0s/-
> ```
>
> Is it right?
Yes correct, and you would be able to also start|stop routes, stop quarkus as well (if posible), and get a lot of statistics as output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1413218288
Thanks @aldettinger I will create a follow up PR for that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415037934
IMHO it should be JVM mode as users can start quarkus and want to have jbang able to manage it locally. So keep it in JVM mode thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092989092
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
and `qute.json` which you added back seems in a wrong directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1507916451
@zbendhiba I am waiting from long time to marge this PR, also I have other changes in line regarding this cli-connector, can you please let me know which branch we are targeting here, is it **apache:3.0.x** ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1507947996
@svkcemk can you rebase from `main` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1095426730
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
yeah, but we are trying to add a JVM-only extension and it should put itest in `integration-tests-jvm` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092790701
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
Well, I think this change should not be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093155029
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -1,38 +1,39 @@
{
- "component": {
Review Comment:
Is there any need to have the `qute.json` file modified in this pr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1095420548
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
> I tried the following steps
>
> ```
> ./mvnw cq:create -N -Dcq.artifactIdBase=cli-connector -Dcq.nativeSupported=false
> ./mvnw clean install -DskipTests
> ```
>
> But it added itest in `integration-tests/cli-connector/` and the building failed with
>
> ```
> [ERROR] Failed to execute goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute (validate-github-workflows) on project camel-quarkus: Execution validate-github-workflows of goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute failed: Integration tests not executed by the CI:
> [ERROR]
> [ERROR] cli-connector
> [ERROR]
> [ERROR] Add the missing test module(s) to tooling/scripts/test-categories.yaml
> ```
>
> @ppalaga Is it a bug in cq-maven-plugin?
No, I would not say it is a bug. Adding to test-categories.yaml needs to be done manually, because it is better to take the actual test execution times into consideration. The plugin does not know those numbers. In the past, I thought of storing the the CI module execution times somewhere, so that the plugin can add the new test to the currently fastest group, but I never come to it. I failed at finding some free metrics storage service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1507443529
@davsclaus We can add it if this is merged.
This needs a rebase from main and moving the old '2.17.0-SNAPSHOT' to '3.0.0-SNAPSHOT'
@svkcemk Would you please rebase and update the version please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1414711567
@davsclaus is there any example for showing how to use this tool?
As you said
> Not sure if you ask if JMX is needed or not? Yes it does - its CLI for development purposes.
Then I think this extension should be only availiable in `DEV` mode, is it right? and it can work with [qurkus dev console](https://quarkus.io/guides/dev-ui)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415040313
However a nice touch we could consider is to automatic include it if you use DEV mode, eg mvn quarkus:dev - and the quarkus dev console (q/dev on web) only requires camel-console and camel-management to offer the data the console need. Its the same data that camel jbang / camel-cli-connector uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093034941
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
@zhfeng I tried to re-generate it using `mvn cq:create -N -Dcq.artifactIdBase=cli-connector` in a separate place and then added it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1514932128
@svkcemk Excuse me again, may I ask you to rebase again? Let's make these tests pass, so that we can merge it tomorrow.
@ppalaga FYI, we want this PR to be merged before releasing 3.0.0-M2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1514417695
> is rebasing againg from main necessary to have those tests pass?
We should try it as I increased the number of retries on artifact download failures. So it could help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093004635
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
Thanks aw I added back to correct place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092984961
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
@svkcemk yeah, I thinks so. Can you share the instructions you used for building? I belive `camel-package-maven-plugin` generates these files but I can not get it working by using `./mvn -f extensions/qute/component/pom.xml clean install`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092987685
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
Yeah I used `mvn clean install -DskipTests` to build the complete project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093183728
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -1,38 +1,39 @@
{
- "component": {
Review Comment:
No, I think we don't need this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092811086
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
Thanks removed from PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1413331844
Not sure if you ask if JMX is needed or not?
camel-cli-connector requires these JARs - So I assume for CEQ then we need extensions for these and to use them here
<!-- insights -->
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-console</artifactId>
</dependency>
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-health</artifactId>
</dependency>
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-management</artifactId>
</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1412000266
Looks a good first step @svkcemk :clap:
Reading the ticket, would be a need to have some follow up prs ? For instance with config and deployment test ?
If yes, maybe [this](https://github.com/apache/camel-quarkus/blob/main/extensions/kubernetes/deployment/src/test/java/org/apache/camel/quarkus/component/kubernetes/cluster/deployment/KubernetesClusterServiceConfigDefaultTest.java) and [that](https://github.com/apache/camel-quarkus/blob/main/extensions/kubernetes/runtime/src/main/java/org/apache/camel/quarkus/component/kubernetes/cluster/KubernetesClusterServiceConfig.java) could serve as examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1094180235
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-cli-connector</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: CLI Connector</name>
+ <description>Integration tests for Camel Quarkus CLI Connector extension</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-cli-connector</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+ <dependency>
Review Comment:
Ok, maybe that might deserve a documentation in another pr then ? Maybe it should even be done in Camel documentation if it's shared across runtimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1094175106
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-cli-connector</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: CLI Connector</name>
+ <description>Integration tests for Camel Quarkus CLI Connector extension</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-cli-connector</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+ <dependency>
Review Comment:
`camel-quarkus-management` added as because its required the `JmxManagementLifecycleStrategy` as default when none of the JMX is configured, I think user need to added it each time or they need to add some JMX configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093158602
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,105 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-cli-connector</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: CLI Connector</name>
+ <description>Integration tests for Camel Quarkus CLI Connector extension</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-cli-connector</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+
+
Review Comment:
Could you please try to format following instructions from the pr first note ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1093181625
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
@svkcemk I tried the following steps
```
./mvnw cq:create -N -Dcq.artifactIdBase=cli-connector -Dcq.nativeSupported=false
./mvnw clean install -DskipTests
```
But it added itest in `integration-tests/cli-connector/` and the building failed with
```
[ERROR] Failed to execute goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute (validate-github-workflows) on project camel-quarkus: Execution validate-github-workflows of goal org.codehaus.gmaven:groovy-maven-plugin:2.1.1:execute failed: Integration tests not executed by the CI:
[ERROR]
[ERROR] cli-connector
[ERROR]
[ERROR] Add the missing test module(s) to tooling/scripts/test-categories.yaml
```
@ppalaga Is it a bug in cq-maven-plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1143201297
##########
extensions-jvm/cli-connector/deployment/pom.xml:
##########
@@ -0,0 +1,63 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-cli-connector-parent</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
Review Comment:
This should be updated to 3.0.0-SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1103798840
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
@ppalaga I tried a fix on https://github.com/l2x6/cq-maven-plugin/pull/145, can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1507253908
Will this make it into a release that you want to use for Q 3.0 final or whats the prognose for this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1168360611
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
Review Comment:
Sorry I missed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1514391167
@davsclaus Yes it is, we just need to have those maven central disconnections fixed.
@jamesnetherton is rebasing againg from main necessary to have those tests pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1514384498
Is all okay for this, as we need this with CEQ v4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1094164732
##########
integration-tests-jvm/cli-connector/pom.xml:
##########
@@ -0,0 +1,100 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>2.17.0-SNAPSHOT</version>
+ <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-test-cli-connector</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: CLI Connector</name>
+ <description>Integration tests for Camel Quarkus CLI Connector extension</description>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-cli-connector</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+ <dependency>
Review Comment:
We add `camel-quarkus-management` here. Does it mean that users would need to add that each time in their own project ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on a diff in pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on code in PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#discussion_r1092970068
##########
extensions/qute/component/src/generated/resources/org/apache/camel/component/qute/qute.json:
##########
@@ -11,7 +11,7 @@
"supportLevel": "Preview",
"groupId": "org.apache.camel.quarkus",
"artifactId": "camel-quarkus-qute-component",
- "version": "2.16.0-SNAPSHOT",
+ "version": "2.17.0-SNAPSHOT",
Review Comment:
@zhfeng I think its was part of the auto generated extension part, I added the quto.json back, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415115576
Thanks a lot @davsclaus for clarifying and I think https://camel.apache.org/manual/camel-jbang.html#_getting_status_of_camel_integrations is the case for running the application with `camel-quarkus-cli-connector`. We could expect to see the simiar output like:
```
PID NAME CAMEL PLATFORM READY STATUS AGE TOTAL FAILED INFLIGHT SINCE-LAST
61818 MyCamel 3.20.0 Quarkus 2.17.0.Final 1/1 Running 28m34s 854 0 0 0s/0s/-
```
Is it right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] svkcemk commented on pull request #4465: #4051 : Add camel-cli-connector extension.
Posted by "svkcemk (via GitHub)" <gi...@apache.org>.
svkcemk commented on PR #4465:
URL: https://github.com/apache/camel-quarkus/pull/4465#issuecomment-1415201244
Thanks I will create a followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org