You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Kito D. Mann (JIRA)" <ji...@apache.org> on 2007/02/14 00:48:05 UTC

[jira] Created: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

web.xml for Testsuite web app missing DTD declarataion
------------------------------------------------------

                 Key: PLUTO-312
                 URL: https://issues.apache.org/jira/browse/PLUTO-312
             Project: Pluto
          Issue Type: Bug
          Components: portlets-testsuite
    Affects Versions: 1.1.0-beta2
         Environment: Windows XP, 1GB RAM, Geronimo 2.0M2
            Reporter: Kito D. Mann
            Priority: Minor
             Fix For: unspecified


The web.xml for the testsuite app is missing the DTD declaration at the top:

<!DOCTYPE web-app PUBLIC
        "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
        "http://java.sun.com/dtd/web-app_2_3.dtd">

Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "Elliot Metsger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliot Metsger resolved PLUTO-312.
----------------------------------

    Resolution: Fixed

> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>         Assigned To: Elliot Metsger
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "Elliot Metsger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477195 ] 

Elliot Metsger commented on PLUTO-312:
--------------------------------------

yes, in AbstractCastorDescriptorService 78-81

            Marshaller marshaller =
                new Marshaller(new DefaultHandler()); //serializer.asDocumentHandler());
            marshaller.setMapping(getCastorMapping());
            marshaller.marshal(object);

You have to call marshaller.setDoctype with the dtd and public id; right now that call is missing.  So when the web.xml is rewritten it is missing the doctype.

Servlet 2.3 uses Doctypes.  Servlet 2.4 uses XSD's.  We can't blindly add the DOCTYPE without knowing if we are assembing a 2.3 or a 2.4 servlet descriptor.



> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>         Assigned To: David DeWolf
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David DeWolf updated PLUTO-312:
-------------------------------

    Fix Version/s:     (was: unspecified)
                   1.1.1
         Assignee: David DeWolf

> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>         Assigned To: David DeWolf
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "Elliot Metsger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477669 ] 

Elliot Metsger commented on PLUTO-312:
--------------------------------------

There are two issues behind this problem:
1) The assember which is used to write out the web.xml doesn't use the WebAppDescriptorService (PLUTO-327)
2) Even if the assembler used the WebAppDescriptorService, the service wouldn't output a doctype anyway. (PLUTO-326)



> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>         Assigned To: Elliot Metsger
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David DeWolf reassigned PLUTO-312:
----------------------------------

    Assignee: Elliot Metsger  (was: David DeWolf)

> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>         Assigned To: Elliot Metsger
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "Kito D. Mann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kito D. Mann updated PLUTO-312:
-------------------------------

    Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)  (was: Windows XP, 1GB RAM, Geronimo 2.0M2)

> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>            Priority: Minor
>             Fix For: unspecified
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PLUTO-312) web.xml for Testsuite web app missing DTD declarataion

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477182 ] 

David DeWolf commented on PLUTO-312:
------------------------------------

This actually appears to be a problem with the assembler.  The source file has the dtd declaration:

http://svn.apache.org/repos/asf/portals/pluto/trunk/pluto-testsuite/src/main/webapp/WEB-INF/web.xml

It must get stripped by castor?

> web.xml for Testsuite web app missing DTD declarataion
> ------------------------------------------------------
>
>                 Key: PLUTO-312
>                 URL: https://issues.apache.org/jira/browse/PLUTO-312
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlets-testsuite
>    Affects Versions: 1.1.0-beta2
>         Environment: Windows XP, 2GB RAM, Geronimo 2.0M2, both Pluto 1.1.0 beta-2 and Pluto 1.1.0 (RC3, unreleased)
>            Reporter: Kito D. Mann
>         Assigned To: David DeWolf
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> The web.xml for the testsuite app is missing the DTD declaration at the top:
> <!DOCTYPE web-app PUBLIC
>         "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
>         "http://java.sun.com/dtd/web-app_2_3.dtd">
> Tomcat doesn't care, but Geronimo (and other servers, I suspect) won't deploy it this way :-).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.