You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/12/23 02:04:23 UTC
[GitHub] codecov-io edited a comment on issue #5769: [refactor] moving some
datasource-related code to the frontend
codecov-io edited a comment on issue #5769: [refactor] moving some datasource-related code to the frontend
URL: https://github.com/apache/incubator-superset/pull/5769#issuecomment-417002399
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=h1) Report
> Merging [#5769](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/eff4e6362c06b954004fd6a8dc0fd5e288abb6a9?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5769 +/- ##
==========================================
+ Coverage 56.14% 56.15% +<.01%
==========================================
Files 518 518
Lines 23044 23032 -12
Branches 2822 2812 -10
==========================================
- Hits 12939 12933 -6
+ Misses 9644 9638 -6
Partials 461 461
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.67% <ø> (-0.7%)` | :arrow_down: |
| [...plore/components/controls/FixedOrMetricControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRml4ZWRPck1ldHJpY0NvbnRyb2wuanN4) | `60.97% <ø> (-0.93%)` | :arrow_down: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5769/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `43.08% <0%> (+2.32%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=footer). Last update [eff4e63...1b95913](https://codecov.io/gh/apache/incubator-superset/pull/5769?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org