You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by "rm5248 (via GitHub)" <gi...@apache.org> on 2023/04/21 13:21:09 UTC

[GitHub] [logging-log4cxx] rm5248 commented on pull request #204: Allow message strings containing quote characters to be logged to a database

rm5248 commented on PR #204:
URL: https://github.com/apache/logging-log4cxx/pull/204#issuecomment-1517827299

   Two things:
   1. If this is to prevent SQL injection, shouldn't we use bound parameters instead?
   2. It looks like the ABI broke; I suspect that this is because `IMPLEMENT_LOG4CXX_OBJECT(MessagePatternConverter)` is now inside of a namespace.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org