You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Eric Covener <co...@gmail.com> on 2014/11/12 02:44:13 UTC

is this pattern in event safe?

is this pattern in event safe?

       apr_pool_clear(cs->p);
        ap_push_pool(worker_queue_info, cs->p);

cs itself is allocated from cs->p (ptrans)

Must cs->p be copied to the stack since MaxMemFree could return these bytes?

(I have been chasing a rare crash in this neighborhood, but this
pattern doesn't seem to actually be the culrpit)

-- 
Eric Covener
covener@gmail.com

Re: is this pattern in event safe?

Posted by Yann Ylavic <yl...@gmail.com>.

On Wed, Nov 12, 2014 at 2:44 AM, Eric Covener <co...@gmail.com> wrote:
> Must cs->p be copied to the stack since MaxMemFree could return these bytes?

+1, *cs is invalid after apr_pool_clear().

Regards,
Yann.