[GitHub] [tinkerpop] divijvaidya commented on issue #1144: TINKERPOP-2238 Fixed all iterator leaks

[GitBox <gi...@apache.org>]

divijvaidya commented on issue #1144: TINKERPOP-2238 Fixed all iterator leaks
URL: https://github.com/apache/tinkerpop/pull/1144#issuecomment-516202060
 
 
   We can do 1 but I don't see a lot of benefit of doing this. Having said that, I don't have any strong opinion on this. Will change.
   
   But for 2, I would keep prefer that `CloseableIterator` and `DefaultCloseableIterator` act as extensions to vanilla iterator operators (as their name suggests) without any domain specific business logic.
   
   `TinkerGraphIterator` contains storage specific logic, i.e. knowledge of when to increment/decrement `StoreIteratorCounter` (different storage might release the iterator at different events) and hence, I am not in favor of adding its functionality to `DefaultCloseableIterator`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services